Skip to content

Fix some evcc issues #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix some evcc issues #10

merged 5 commits into from
Feb 11, 2025

Conversation

HappyTobi
Copy link
Owner

Fix some issues at the evcc enable command
Add new github action release generation

@HappyTobi HappyTobi requested a review from Copilot January 17, 2025 20:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

pkg/cmd/evcc/evcc.go:98

  • The comment 'use fallback from middleware' is missing a space after the '//'. It should be 'use fallback from middleware'.
//use fallback from middleware

pkg/cmd/evcc/evcc.go:121

  • [nitpick] The variable name 'current' is ambiguous. It should be renamed to 'chargePower' for better clarity.
current, err := evseService.CurrentChargePower()

pkg/cmd/evcc/evcc.go:157

  • The comment 'change 16 -> 16000' is unclear. It should explain that the current is being converted from amperes to milliamperes.
//change 16 -> 16000

@HappyTobi HappyTobi merged commit e16db46 into main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant