Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSK_MQ_DUNGEON_COUNT Value defined using #define in header file #4206

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RSK_MQ_DUNGEON_COUNT Value defined using #define in header file #4206

wants to merge 2 commits into from

Conversation

ganesh1828
Copy link

@ganesh1828 ganesh1828 commented Jun 3, 2024 •
edited
Loading

This PR tries to solve #4196
The hardcoded value of RSK_MQ_DUNGEON_COUNT is defined as a macro in the randomizerTypes.h file.

@ganesh1828 ganesh1828 mentioned this pull request Jun 3, 2024
Open
inspectredc
inspectredc reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@inspectredc inspectredc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to name this to something like MAX_MQ_DUNGEON_COUNT instead? RSK implies it being a randomiser settings key rather than a constant expression

@ganesh1828
Copy link
Author

Hi @inspectredc did the changes as per your comment.
Please review it.

@Malkierian
Copy link
Contributor

Resolve the conflicts and I'll get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inspectredc inspectredc inspectredc approved these changes

@Pepe20129 Pepe20129 Pepe20129 approved these changes

Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganesh1828 @Malkierian @Pepe20129 @inspectredc