Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mweep animation speed affected by enhancement #4452

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JordanLongstaff
Copy link
Contributor

@JordanLongstaff JordanLongstaff commented Oct 20, 2024

The "King Zora Speed" enhancement now affects the speed of King Zora's mweeping, not just his movement.

Here it is at x5 speed, in all its mweeping glory.

fast.mweep.mp4

Build Artifacts

@larsy1995
Copy link

What the Mweep did I just listen to??

Malkierian
Malkierian previously approved these changes Oct 20, 2024
@garrettjoecox
Copy link
Contributor

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

@JordanLongstaff
Copy link
Contributor Author

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

Visual effect. That's it.

I could add a checkbox to control this mod.

@Malkierian
Copy link
Contributor

Hmm, I guess I do agree it's a bit more code invasive than I'd like, but I'm having trouble figuring out how it could be possible in a hook.

@Malkierian Malkierian dismissed their stale review October 22, 2024 16:50

Need to re-think invasiveness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants