Skip to content

Mweep animation speed affected by enhancement#4452

Closed
JordanLongstaff wants to merge 1 commit intoHarbourMasters:developfrom
JordanLongstaff:mweep-animation-speed
Closed

Mweep animation speed affected by enhancement#4452
JordanLongstaff wants to merge 1 commit intoHarbourMasters:developfrom
JordanLongstaff:mweep-animation-speed

Conversation

@JordanLongstaff
Copy link
Contributor

@JordanLongstaff JordanLongstaff commented Oct 20, 2024

The "King Zora Speed" enhancement now affects the speed of King Zora's mweeping, not just his movement.

Here it is at x5 speed, in all its mweeping glory.

fast.mweep.mp4

Build Artifacts

@larsy1995
Copy link
Contributor

What the Mweep did I just listen to??

Malkierian
Malkierian previously approved these changes Oct 20, 2024
@garrettjoecox
Copy link
Contributor

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

@JordanLongstaff
Copy link
Contributor Author

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

Visual effect. That's it.

I could add a checkbox to control this mod.

@Malkierian
Copy link
Contributor

Hmm, I guess I do agree it's a bit more code invasive than I'd like, but I'm having trouble figuring out how it could be possible in a hook.

@Malkierian Malkierian dismissed their stale review October 22, 2024 16:50

Need to re-think invasiveness.

@aMannus
Copy link
Contributor

aMannus commented Jan 11, 2025

I'm going to be honest, I'm not a big fan of this. If it should exist, it should also live in a hook, but it also just feels worse than the previous implementation of it, both visually and in code. Again, would love to hear what others think, but I'd rather not have this in.

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Jan 11, 2025

I personally dislike it, and would want it behind an option if at all, but am not sure if it's worth the option bloat. maybe if there's a silly tag in audio customization? But I think you could argue then for just allowing people to change the speed of any sound instead....

@Archez
Copy link
Contributor

Archez commented Jan 11, 2025

Echoing others, I don't really like or want the added complexity for these results either. It's not worth an extra option in my mind, so I'd rather not merge at all.

@JordanLongstaff
Copy link
Contributor Author

Sounds like the preference, then, is to abandon this.

@JordanLongstaff JordanLongstaff deleted the mweep-animation-speed branch January 12, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants