fix: prefer WebSockets over XMPP #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we preferred XMPP because there was a concern that the WebSockets API might change or go away, however since the product line has been discontinued there is much less risk of a firmware update breaking the WebSockets. Since the WebSocket version is more stable, and does not have the blocking I/O issues that XMPP does, its generally a better choice to try first. https://codeberg.org/poezio/slixmpp/issues/3582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we preferred XMPP because there was a concern that the WebSockets API might change or go away, however since the product line has been discontinued there is much less risk of a firmware update breaking the WebSockets. Since the WebSocket version is more stable, and does not have the blocking I/O issues that XMPP does, its generally a better choice to try first. Additionally the XMPP implementation used on the hub has known vulns.
In theory we should never fallback to XMPP with this change even if its enabled unless the WebSocket port is blocked