Merged
Conversation
Owner
|
Hi @drpaprika, Thanks for opening this PR. You are right - the total track is not defined correctly. This was an oversight on my part. This can be updated to include the image surface, and tests can be updated. Happy to help here if needed. Best, |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #212 +/- ##
=========================================
Coverage ? 95.51%
=========================================
Files ? 162
Lines ? 9016
Branches ? 0
=========================================
Hits ? 8612
Misses ? 404
Partials ? 0
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Thanks for your feedback I fixed the tests, it should be ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
total_trackoperand toParaxialOperand.It is called using:
It appears that currently the total track is computed in
surface_group.pyusingz = self.positions[1:-1]. The last surface to image distance is not accounted for, is it intended ?I assumed it was not and corrected it, as it makes sense to me to include the sensor distance in the computation.
Therefore some tests fail, I'll update them or revert the total track computation according to your inputs.
Best,
drpaprika