total_track operand

[drpaprika]

Adds the total_track operand to ParaxialOperand.
It is called using:

input_data = {'optic': lens}
problem.add_operand(
    operand_type='total_track',
    target=100,  # [mm]
    weight=1,
    input_data=input_data,
)

It appears that currently the total track is computed in surface_group.py using z = self.positions[1:-1]. The last surface to image distance is not accounted for, is it intended ?
I assumed it was not and corrected it, as it makes sense to me to include the sensor distance in the computation.
Therefore some tests fail, I'll update them or revert the total track computation according to your inputs.

Best,
drpaprika

[HarrisonKramer]

Hi @drpaprika,

Thanks for opening this PR. You are right - the total track is not defined correctly. This was an oversight on my part. This can be updated to include the image surface, and tests can be updated. Happy to help here if needed.

Best,
Kramer

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##             master     #212   +/-   ##
=========================================
  Coverage          ?   95.51%           
=========================================
  Files             ?      162           
  Lines             ?     9016           
  Branches          ?        0           
=========================================
  Hits              ?     8612           
  Misses            ?      404           
  Partials          ?        0           

Files with missing lines	Coverage Δ
optiland/optimization/operand/operand.py	98.30% <ø> (ø)
optiland/optimization/operand/paraxial.py	97.67% <100.00%> (ø)
optiland/surfaces/surface_group.py	94.81% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[drpaprika]

Thanks for your feedback I fixed the tests, it should be ready to merge