-
Notifications
You must be signed in to change notification settings - Fork 61
Feature/angle vs height #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods and improved data handling
…and functionality
- Updated _plot_angle_vs_height to support color mapping based on scan range. - Modified plot_data_list structure to include scan_range and legend_label. - Improved title generation to include individual trace labels. - Added colorbar to the plot for better visualization of scan range. - Adjusted view method to determine colorbar label based on fixed coordinates. - Refactored coordinate handling in PupilIncidentAngleVsHeight and FieldIncidentAngleVsHeight classes for clarity.
…vs height analysis
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 95.51% 95.51% -0.01%
==========================================
Files 162 163 +1
Lines 9016 9133 +117
==========================================
+ Hits 8612 8723 +111
- Misses 404 410 +6
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angle vs. Height Analysis
Represents an analysis of incident angle vs. image height by varying through all pupil/field coordinates for a given image field/pupil point.
Example: