Fix for incorrect handling of CLICK_EVENT in FlxUIPopup#259
Open
UncertainProd wants to merge 4 commits intoHaxeFlixel:devfrom
Open
Fix for incorrect handling of CLICK_EVENT in FlxUIPopup#259UncertainProd wants to merge 4 commits intoHaxeFlixel:devfrom
CLICK_EVENT in FlxUIPopup#259UncertainProd wants to merge 4 commits intoHaxeFlixel:devfrom
Conversation
Member
|
Can you do me a favor and merge the dev branch back into your branch. I made changes to the github actions |
… flxuipopup-fix
Author
|
Done |
Member
|
I'm trying out the demo locally, without this change, and I can't reproduce any specific error on html5 with any of the popups. What are the steps to reproduce? |
Author
|
In the RPG Interface demo, if you click |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like FlxUIPopup was expecting one of the event paramters in
getEventto be either "affirm", "cancel" or "alt" but that never happens (even the default_popup.xml file never mentions "affirm", "cancel" or "alt" https://github.com/HaxeFlixel/flixel-ui/blob/dev/assets/xml/default_popup.xml ). This should remove references to that and only uses thebuttonAmountparameter when handling click events for FlxUIPopup. This should also fix HaxeFlixel/flixel-demos#267