Map improve remove speed for large map and high percentage of element removed#608
Draft
yuxiaomao wants to merge 5 commits intoHaxeFoundation:masterfrom
Draft
Map improve remove speed for large map and high percentage of element removed#608yuxiaomao wants to merge 5 commits intoHaxeFoundation:masterfrom
yuxiaomao wants to merge 5 commits intoHaxeFoundation:masterfrom
Conversation
This commit will resize down the map when its n < max*0.75, and reduce the remove execution time for a big but empty map.
Collaborator
Author
|
I just implemented the Robin Hood Hashing for Hashmap. (References : https://www.youtube.com/watch?v=4cTKiTQtS_k&t=893s , https://programming.guide/robin-hood-hashing.html)
The overall performance is now comparable to javascript target - even faster in some situations. |
Collaborator
Author
|
TODO: after we're sure of this change, we'll need memdump + debugger support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR try to deal with the high execution time when removing large amount of entries for a large map. Still not very good at performance but at least some improvement.
What cause the problem as far as I understand: When removing a large amount of entries, map's freelist (the one containing all empty indexes) increase in size, and manipulating this list becomes costly when the map's memory is very fragmented.
The proposed solution defragment the map when the size of freelist is bigger than a threshold.
The defragment method is moving elements in map.
The threshold is chosen in experimentation, to do not increase the execution time when removing 10% of elements and/or 100% of elements. It is a very high threshold and is only impacting the performance when map size reach around 500,000.
Performance comparison before => after
Test code: