Remove PAD_64_VAL from hlc.h #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haxe only used this macro in the Haxe development branch for less than a month in 2016 outside of any official releases. It was added in: HaxeFoundation/haxe@8776783#diff-3f2c398bad220eadd039e136de740887e42145b512add1e72a48b2b8ba99062eR5821 and removed in: HaxeFoundation/haxe@65705a1#diff-3f2c398bad220eadd039e136de740887e42145b512add1e72a48b2b8ba99062eL6011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haxe only used this macro in the Haxe development branch for less than a month in 2016 outside of any official releases.
It was added in:
HaxeFoundation/haxe@8776783#diff-3f2c398bad220eadd039e136de740887e42145b512add1e72a48b2b8ba99062eR5821
and removed in:
HaxeFoundation/haxe@65705a1#diff-3f2c398bad220eadd039e136de740887e42145b512add1e72a48b2b8ba99062eL6011
So it should be fine to remove it.
Similarly to #807, it is best to avoid hlc.h from polluting the namespace.