Skip to content

feat: (de)serialize any instances of Error in QueryState.error while (de)hydrating #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: (de)serialize any instances of Error in QueryState.error while (de)hydrating #116

wants to merge 10 commits into from

Conversation

n0099
Copy link

@n0099 n0099 commented May 27, 2025 •
edited
Loading

🔗 Linked issue

#108

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Based on #115.
Users will need to addKnownErrorConstructor(SomeDerviedError) if they're using something like e instanceof SomeDerviedError: n0099/open-tbm@1f8a220#diff-0f75652bede5b3ab02fab6d24c628b1963347f8aa2d54ff8e23bd738a0941250R18-R26

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

n0099 added 9 commits May 23, 2025 22:25
@n0099
feat: allow passing DehydrateOptions as nuxt module option to `dehy…
99dcfc7 
…drate()`
@n0099
fix: workaround for cannot pass function to module config: nuxt/nuxt#…
6f7dfce 
…20933
@n0099
Revert "fix: workaround for cannot pass function to module config: nu…
b36330e 
…xt/nuxt#20933"

This reverts commit 6f7dfce.
@n0099
Revert "feat: allow passing DehydrateOptions as nuxt module option …
84958af 
…to `dehydrate()`"

This reverts commit 99dcfc7.
@n0099
feat: allow returning HydrateOptions & DehydrateOptions in `virtu…
90fe9ca 
…al:pluginHook.ts`
@n0099
feat: better api of PluginHookReturn.pluginReturn
6ee7a5d
@n0099
feat: (de)serialize any instances of Error in QueryState.error wh…
b453fcd 
…ile (de)hydrating
@n0099
fix: not (de)serialize QueryState.fetchFailureReason and `MutationS…
843764a 
…tate.failureReason` while (de)hydrating
@n0099
feat: add PluginHookReturn.(de)serializeErrorOptions
811583c
@n0099 n0099 requested a review from Hebilicious as a code owner May 27, 2025 03:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a8a2c49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n0099 n0099 mentioned this pull request May 27, 2025
Open
Hebilicious
Hebilicious approved these changes May 27, 2025
View reviewed changes
Copy link
Owner

@Hebilicious Hebilicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@n0099
fix: always (de)hydrate query/mutation without error
a8a2c49 
fix: only (de)serialize `state.fetchFailureReason` and `state.failureReason` when it is or like error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hebilicious Hebilicious Hebilicious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0099 @Hebilicious