-
Notifications
You must be signed in to change notification settings - Fork 365
hotfix: session bugging a bit when clicking around #3465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ No documentation updates required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR addresses session page performance and loading state management issues, focusing on optimizing refresh behavior and consolidating loading states.
- Changed initial
isLive
state tofalse
in/web/pages/sessions/[session_id].tsx
to prevent automatic session refreshes - Added consolidated
isAnyLoading
state in/web/components/templates/sessions/sessionsPage.tsx
to streamline loading indicators - Bug identified: Duplicate
isLoading
check in loading state conditions needs to be removed - Wrapped SessionContent in React Fragment for proper component rendering
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
return ( | ||
isLoading || | ||
allNames.isLoading || | ||
allNames.isRefetching || | ||
isLoading || | ||
names.isLoading || | ||
names.isRefetching | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: isLoading
is listed twice in the conditions, which is redundant and may mask other loading states
return ( | |
isLoading || | |
allNames.isLoading || | |
allNames.isRefetching || | |
isLoading || | |
names.isLoading || | |
names.isRefetching | |
); | |
return ( | |
isLoading || | |
allNames.isLoading || | |
allNames.isRefetching || | |
names.isLoading || | |
names.isRefetching | |
); |
Summary
|
No description provided.