-
-
Notifications
You must be signed in to change notification settings - Fork 207
Make deleting a phantom space a separate backspace press #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It should definitely be a setting, this behavior appears like a bug to a user who doesn't know of this setting. It's not working for glide typing, because the code is after the |
If it's possible, a changed cursor would definitely help. Maybe also some styling is possible using |
Should I combine it with the existing No autospace when pressing shift setting into a list preference (that would require some upgrade logic obviously)? Should they be mutually exclusive?
Fixed, but without updating suggestions, since that would prevent rejecting the gestured word. |
See #1805 (comment). |
Makes sense. Here the need for an indicator is clearly greater than for selecting a suggestion, as the underline under the word is there all the time. |
Currently, when you press backspace, any existing phantom space is canceled, and the character before it is deleted.
With this change, if in phantom space mode, only that space is deleted on the first press, to give the user more control.
This is another alternative for the No autospace when pressing shift setting, which is problematic in some situations. See #1773, #1777.
Should this be guarded by a setting?
#1805 could make this clearer.
I tried to make the code change as light as possible, but I might have missed some details.