Upgraded the /dm list command
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed singleton usage for plugin class to DI - Removed some static methods in plugin class in favor of their instance counterparts - Split the command class into subcommand classes - Added pagination to the menu list command. The old list format is still available using '/dm list all' - Added an option to suggest the admin '/dm open menu' command in the menu list - Added an option to change the page size for the menu list - Added a new GeneralConfig class to hold and handle the general values from config.yml - Moved some constants around to avoid unnecessary passing of variables
Tanguygab
reviewed
Jan 2, 2025
src/main/java/com/extendedclip/deluxemenus/command/subcommand/OpenCommand.java
Outdated
Show resolved
Hide resolved
Tanguygab
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; Improved
/dm listcommand and some general cleanup.Changes were tested on Paper 1.21.1 and Paper 1.21.3
Closes #133