Skip to content

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Sep 5, 2023

This should be get tested well, I don't want games to randomly quit :)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty added the pr:testing This PR is in testing, don't merge. label Sep 24, 2023
@CommandMC
Copy link
Collaborator

Did this actually do something? When calling a runner, we wait for stdout/stderr to be closed. This only happens once all Wine processes quit. So I wouldn't expect this to ever help, say, a stuck launcher or something

Closing for now, feel free to re-open/re-create if the change is helpful

@CommandMC CommandMC closed this Oct 18, 2025
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:testing This PR is in testing, don't merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants