Skip to content

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Dec 31, 2023

Fixes #3352

haven't tested this yet

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 31, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Etaash-mathamsetty
Copy link
Member Author

won't be merging until I can test this

@arielj
Copy link
Collaborator

arielj commented Jan 2, 2024

This is not working correctly. I'm testing for example with Alwa's Awakening. The game has both windows and linux builds.

With this PR it doesn't show the compatibility component at all, when installed for any of the platforms and even when not installed.

We should only hide it when the native version of a game is installed.

@flavioislima flavioislima added the pr:wip WIP, don't merge. label Jan 7, 2024
@CommandMC
Copy link
Collaborator

Closing due to inactivity. Feel free to re-open/re-create if you're interested in continuing this

@CommandMC CommandMC closed this Oct 18, 2025
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P pr:wip WIP, don't merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proton compabitility is displayed for native games

4 participants