[Fix] Windows development fixes #3458
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
HamsterExAstris
changed the title
HamsterExAstris
changed the title
| unlinkFile(__dirname) | ||
| }).toThrowError( | ||
| `Couldn't remove ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities!` | ||
| `Couldn't remove ${workDir}${path.sep}src${path.sep}backend${path.sep}wine${path.sep}manager${path.sep}downloader${path.sep}__tests__${path.sep}utilities!` |
There was a problem hiding this comment.
we should use path.join here like path.join(workDir, 'src', 'backend', ...) instead interpolating path.sep, it's easier to read and should take care of using the right separator
There was a problem hiding this comment.
Thanks, that is much more readable!
HamsterExAstris
force-pushed
the
force_lf_checkout
branch
from
a7eddd3 to
a21c38f
Compare
| }) | ||
| ).resolves.toStrictEqual( | ||
| `Succesfully unzip ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities/../test_data/test.tar.xz to ${workDir}/src/backend/wine/manager/downloader/__tests__/utilities/test_unzip.` | ||
| `Succesfully unzip ${path.join( |
There was a problem hiding this comment.
was this needed to fix the issue with the prettier as well?
seems unrelated.
|
Question: this supposed to fix the issue where when we try |
|
Closing due to inactivity. Feel free to re-open/re-create if you're interested in continuing this |
4 participants
Prettier forces all files to have Unix (LF) line endings. When a Windows user has
core.autocrlfset to true in their global.gitconfig, commits use LF line endings but the files on disk use CRLF. This leads to spurious Prettier differences, causing the commit hook to fail.This overrides that global setting, using LF endings for text files on disk regardless of the
core.autocrlfsetting.It also fixes some tests that assumed Unix directory separators.
Use the following Checklist if you have changed something on the Backend or Frontend: