Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Show tab and message when Cloud Saves are not supported #4280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 15, 2025

Currently, we do not display the Cloud Saves Sync tab in the game's settings if the game shows that it doesn't support cloud saves in the metadata and if the game is linux native.

It had happened many times in the past that users can't find the Cloud Saves Sync tab and they think there's some bug when, in reality, they may be hitting one of those conditions.

So, instead of hiding the tab and letting the user figure out why they can't see it, it's more user-friendly to show the tab and explain why it doesn't work. And in the case of a GOG linux-native game we can also instruct the user to use the Windows version instead so they don't need to figure that out.

I did leave the tab ignored for Amazon games and Sideloaded apps/games because I understand Amazon doesn't cloud saves at all and for sideloaded games it makes no sense.

This is similar to what we do with the Gamescope tab, that we show it with an error message if the gamescope binary cannot be found.

The style is not great but I used the same as the Gamescope tab for consistency (just a div with red text (this is not great for themes though))


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 15, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 15, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant