Skip to content

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Aug 5, 2025

Another issue related to the scroll happening in document.body instead of window.

When navigating with a controller, this improves the position of the scroll so the focused card is scrolled into view. This was already a thing but it broke along with the other scroll-related features.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, biliesilva, flavioislima and imLinguin and removed request for a team August 5, 2025 01:00
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 5, 2025
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related to this: Another place using window is the gamepad navigation, which seems to no longer get the focus and blur events. Adding them to document.body instead seems to not work in that case

@arielj
Copy link
Collaborator Author

arielj commented Aug 8, 2025

Somewhat related to this: Another place using window is the gamepad navigation, which seems to no longer get the focus and blur events. Adding them to document.body instead seems to not work in that case

I'm so confused, not sure what broke the events on the window object :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants