Skip to content

Conversation

aidalgol
Copy link
Contributor

Similar to the log message,

We are [not] running in a Flatpak container

Add a log message for AppImage,

We are [not] running from an AppImage

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@aidalgol aidalgol mentioned this pull request Aug 11, 2025
4 tasks
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can make all the steamdeck/flatpak/appimage block conditional to show up only for linux? it adds noise on macos and windows

@aidalgol aidalgol requested a review from arielj August 16, 2025 20:25
Log the Steamdeck/AppImage/Flatpak messages only on Linux, to reduce
noise in logs for macOS and Windows.
@CommandMC
Copy link
Collaborator

Note: The Steam Deck check is intentionally not Linux-specific (by detecting hardware details instead), that one can stay IMO. Yes, it's unlikely that anyone will install Windows on their Deck & use Heroic, but still; whether a device is a Steam Deck has nothing to do with the device's OS

Either way, the actual change here looks good to me

Based on review feedback.  The Steamdeck check looks at hardware, and so
could still be relevant to Windows running on a Steamdeck.
@CommandMC CommandMC merged commit 471de4f into Heroic-Games-Launcher:main Oct 18, 2025
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants