Skip to content

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented Aug 14, 2025

Users often toggle this option by mistake, either while only using one GPU (seems like a warning wasn't enough there), or thinking they have to toggle it for their dGPU to be used. To combat this, remove the toggle in the Frontend (but still handle the option for existing setups); if users really need those env vars, they can add them themselves


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested a review from a team August 14, 2025 19:36
@CommandMC CommandMC self-assigned this Aug 14, 2025
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 14, 2025
@CommandMC CommandMC requested review from Etaash-mathamsetty, Nocccer, arielj, biliesilva, flavioislima and imLinguin and removed request for a team August 14, 2025 19:36
@arielj
Copy link
Collaborator

arielj commented Aug 14, 2025

I wonder if we can just remove this setting.

Maybe it was needed before but lately I only see this causing issues. And I feel like it's some edge case that if someone knows they need it (to toggle it intentionally) they can probably just add the variable that we add?

Or maybe we can change the name of the setting to be Set NVIDIA_PRIME=... environment variable, so users who have no idea what that is don't turn it on.

Because I feel some users will still toggle that incorrectly when trying to make something work and leave it on by mistake sometimes.

@CommandMC
Copy link
Collaborator Author

Definitely in favor of removing this in the long run, just didn't want to risk breaking existing setups

@arielj
Copy link
Collaborator

arielj commented Aug 21, 2025

maybe we can remove the UI but keep the setting handled in the backend if already set to true?

that way existing setups won't break and new users won't turn it on by mistake

Still respect the option in the backend to not break existing setups, but don't
make it toggleable anymore (users are misusing it)
@CommandMC CommandMC force-pushed the feat/clarify-use-dgpu branch from bffc897 to d1d421c Compare August 25, 2025 15:02
@CommandMC CommandMC changed the title [Feat] Clarify "Use dedicated graphics card" / PRIME run option [Feat] Remove "Use dedicated graphics card" / PRIME run option Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants