-
-
Notifications
You must be signed in to change notification settings - Fork 530
[Tech] Simplified adding runners #4895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unbelievableflavour
wants to merge
20
commits into
Heroic-Games-Launcher:main
Choose a base branch
from
unbelievableflavour:simplified-adding-runners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Tech] Simplified adding runners #4895
unbelievableflavour
wants to merge
20
commits into
Heroic-Games-Launcher:main
from
unbelievableflavour:simplified-adding-runners
+244
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These objects are always available in the store.
CommandMC
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering your recent PRs I was practically waiting for something like this, and considering my recent PRs I assume it's no surprise that I'm very much in favor of this
I just have a few comments on the implementation
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR moves a ton of runner specific code into a single hook so that it's a LOT easier to add new runners to the project.
I've added a hook that will just give you the required info if you need it instead of manually defining every single runner the project has in all frontend components.
Use the following Checklist if you have changed something on the Backend or Frontend: