Skip to content

Conversation

unbelievableflavour
Copy link

@unbelievableflavour unbelievableflavour commented Aug 22, 2025

This MR moves a ton of runner specific code into a single hook so that it's a LOT easier to add new runners to the project.
I've added a hook that will just give you the required info if you need it instead of manually defining every single runner the project has in all frontend components.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@unbelievableflavour unbelievableflavour changed the title Simplified adding runners [Tech] Simplified adding runners Aug 22, 2025
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering your recent PRs I was practically waiting for something like this, and considering my recent PRs I assume it's no surprise that I'm very much in favor of this
I just have a few comments on the implementation

@unbelievableflavour unbelievableflavour changed the title [Tech] Simplified adding runners [Tech] Simplified adding runners (Frontend) Aug 25, 2025
@unbelievableflavour unbelievableflavour changed the title [Tech] Simplified adding runners (Frontend) [Tech] Simplified adding runners Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants