Add new environment variable: HEROIC_EXEC.

[patlefort]

Add new environment variable: HEROIC_EXEC. This variable tells heroic what executable should be used to launch itself, if defined.

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[patlefort]

I have read the CLA Document and I hereby sign the CLA

[arielj]

not sure I understand what is this for, there's no context and no explanation as to why this is needed/useful

[patlefort]

Related issue: #4951 . With all due respect I disagree about "packaging issue" when it requires patching source code and it's a simple 3 lines fix.

[arielj]

who would be in charge of setting that environment variable? the distro maintainer? the package maintainer? the user?

I don't think the distro maintainer is the right one cause they don't know which package the user is going to install

if it's the package maintainer, they can also apply a proper fix to keep thing working without this env like it's explained in that issue

if it's expected that the user would add this, then it's really bad UX cause the user would have to first know they are affected by this problem and then manually go and apply a workaround, and it's caused by the package maintainer, the official UX is that it just works

I think this env variable is a band-aid that would allow non-official package maintainers to not do the correct thing and throws the burden of fixing it to the heroic support (that would have to figure out this is the case and then instruct users) or to the user (to do the research or look for help)

I don't agree that this is a 3-lines fix, it's 3-lines workaround that doesn't really fix the problem unless something else is changed by the user to make it work

[patlefort]

I'm not aware of any other way. You can't know how exactly your software was launched which is why I used an environment variable. It's not caused by anyone in particular, it's just how it work. There could be other uses, like wrapping heroic with firejail for security, especially when it is using many binaries downloaded from github. In that case, even the -bin package in the AUR would break but could make use of that variable.

Patching sources is supposed to be the last resort when upstream can't or won't fix or change things. It's obviously better to have a way supported by upstream.