Skip to content

Conversation

UlyssesZh
Copy link

Add this env var to give the before/after launch script more possibilities.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Oct 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@UlyssesZh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@UlyssesZh
Copy link
Author

recheck

@UlyssesZh UlyssesZh changed the title Add HEROIC_GAME_SETTINGS env var to before/after launch script Add HEROIC_GAME_SETTINGS and HEROIC_GAME_INFO env var to before/after launch script Oct 6, 2025
@CommandMC
Copy link
Collaborator

CommandMC commented Oct 10, 2025

I'm not sure how I feel about pre- and post-launch scripts getting this smart. Ideally if you need this much info, it's better to be implemented as an actual feature in Heroic
What's your use case for this?

@UlyssesZh
Copy link
Author

Having more information is better because more things are now possible with launch scripts. It does not matter what the actual use case is.

My use case involves using the Wine binary. I have my own system of cloud game save, and usually how I synchronize game save data with the cloud is to replace the game save files with symlinks to files in the dir synchronized with my cloud drive. This works for most games, but one game uses the registry to save data, and I should not simply synchronize the whole registry because there are other data in the registry that are not meant to be the same across different machines. In order to have a cloud save, I want to write a pre-launch script to import the cloud save data into the registry and a post-exit script to export the save data to the cloud save. I use Wine to do the registry manipulation, so the script needs to know what the correct version of Wine is.

@CommandMC
Copy link
Collaborator

I see. My point was that, if you're creating a script this complex, it might be beneficial to implement into Heroic itself (since it's likely helpful to more people than just you). Since this is a pretty specific use case though, I do see why you'd want to keep this as pre- and post-launch scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants