Fix Volume update size handling #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
units of GiB. Terraform stores Volume "Size" in units of GB. For Create, GB is converted to GiB, but for Update, GB needs to be converted to KiB. See quake PR#5749 for more detail.
mchuang3
requested review from
anurag-shrivastav,
chaitra-mylarappachar,
harinathakotha and
dbozzato81
as code owners
neilgierman
approved these changes
Jul 7, 2025
Not much unit test code in this repo, and none for Volume, but there is test coverage in the Acceptance tests here, which is how I noticed the failure in the depenabot update. Definitely would be good to add unit tests at some point. For now, relying on the acceptance tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project API for Volume Create is in units of GiB. Terraform stores Volume "Size" in units of GB. For Create, GB is converted to GiB, but for Update, GB needs to be converted to KiB. See quake PR#5749 for more details.
Note: this issue is currently blocking dependabot update of the Client API for Boot-from-SAN related changes (PR #266). Once this PR is merged, will update #266.