-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
支持下载光影包 #4359
base: main
Are you sure you want to change the base?
支持下载光影包 #4359
Conversation
@3gf8jv4dv Have a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Modrinth’s content, mostly good. CurseForge and mixed cases will be tested later.
When I opened the build for the first time, visited the shaderpacks interface after downloading two instances, and clicked on the first item, an error occurred. This error message appears in the form of a Windows error message window.
This situation did not happen again subsequently. I do not know how to make it happen again, here is the error message.
Details
程序出现未知错误:Object reference not set to an instance of an object.
at PCL.MyCompItem.ProjectClick(MyCompItem sender, EventArgs e)
at PCL.MyCompItem._Lambda$__R0-1(Object a0, MouseButtonEventArgs a1)
at PCL.MyCompItem.Button_MouseUp(Object sender, MouseButtonEventArgs e)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
at System.Windows.UIElement.OnPreviewMouseUpThunk(Object sender, MouseButtonEventArgs e)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
at System.Windows.Input.InputManager.ProcessStagingArea()
at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
错误类型:System.NullReferenceException
It looks like this was ported from resource pack PR, with one translation not revised.
When selecting Modrinth’s shader category Vanilla Shader, PCL shows nothing, but there are items in this category on Modrinth.
Fix later. |
fix: 无法获取 Modrinth 上 Vanilla Shader 分类的光影(原 URL 写错了)
Issues mentioned above are resolved in 94ccc00. However, for the first issue, I cannot reproduce. Maybe it's just a random error? |
Now I can reproduce the issue... |
Close #396 (关联投票 #2768 )
需要绘制图标