Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持下载光影包 #4359

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

支持下载光影包 #4359

wants to merge 6 commits into from

Conversation

Pigeon0v0
Copy link
Collaborator

Close #396 (关联投票 #2768 )

需要绘制图标

@Pigeon0v0 Pigeon0v0 added · 新功能 等待确认 已经过社区确认,等待开发者确认 labels Jul 27, 2024
@Pigeon0v0
Copy link
Collaborator Author

@3gf8jv4dv Have a test?

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Modrinth’s content, mostly good. CurseForge and mixed cases will be tested later.


When I opened the build for the first time, visited the shaderpacks interface after downloading two instances, and clicked on the first item, an error occurred. This error message appears in the form of a Windows error message window.

This situation did not happen again subsequently. I do not know how to make it happen again, here is the error message.

Details
程序出现未知错误:Object reference not set to an instance of an object.
   at PCL.MyCompItem.ProjectClick(MyCompItem sender, EventArgs e)
   at PCL.MyCompItem._Lambda$__R0-1(Object a0, MouseButtonEventArgs a1)
   at PCL.MyCompItem.Button_MouseUp(Object sender, MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnPreviewMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
错误类型:System.NullReferenceException

It looks like this was ported from resource pack PR, with one translation not revised.

Preview


When selecting Modrinth’s shader category Vanilla Shader, PCL shows nothing, but there are items in this category on Modrinth.

Preview

@Pigeon0v0
Copy link
Collaborator Author

Fix later.

@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 🟦 推迟 and removed 等待确认 已经过社区确认,等待开发者确认 labels Jul 27, 2024
fix: 无法获取 Modrinth 上 Vanilla Shader 分类的光影(原 URL 写错了)
@Pigeon0v0
Copy link
Collaborator Author

Issues mentioned above are resolved in 94ccc00. However, for the first issue, I cannot reproduce. Maybe it's just a random error?

@Pigeon0v0
Copy link
Collaborator Author

Now I can reproduce the issue...

@3gf8jv4dv 3gf8jv4dv mentioned this pull request Sep 16, 2024
3 tasks
@allMagicNB
Copy link
Contributor

已知问题:翻页之后点最后一项会炸
image

@LTCatt LTCatt added 暂无计划 短期内没有制作该项的计划 and removed 处理中 开发者正在调查或处理该项 🟦 等待 labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
· 新功能 暂无计划 短期内没有制作该项的计划
Projects
None yet
Development

Successfully merging this pull request may close these issues.

添加光影下载
4 participants