Improve code quality #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyPouya
force-pushed
the
refactor/improve-code-quality
branch
from
0acd4c5 to
9f0e95f
Compare
There was a problem hiding this comment.
Pull Request Overview
This MR aims to improve code quality by refining the CI workflow configuration for Android tests.
- Updated the CI pipeline to run debug unit tests instead of all tests.
Files not reviewed (19)
- .editorconfig: Language not supported
- app/build.gradle.kts: Language not supported
- app/src/androidTest/java/com/pouyaheydari/androidappupdater/ExampleInstrumentedTest.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/utils/GetUpdaterDSLStoreList.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/utils/GetUpdaterNormalStoreList.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/android/MainActivity.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/ComposeSampleActivity.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/theme/Color.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/theme/Theme.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/theme/Type.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/ComposePreviewData.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/Constants.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/DSLPreviewData.kt: Language not supported
- app/src/main/res/layout/activity_main.xml: Language not supported
- app/src/main/res/values/strings.xml: Language not supported
- appupdater/build.gradle.kts: Language not supported
- appupdater/gradle.properties: Language not supported
- appupdater/src/androidTest/java/com/pouyaheydari/appupdater/TestUtils.kt: Language not supported
- appupdater/src/main/AndroidManifest.xml: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/android.yml:26
- Verify if using './gradlew testDebugUnitTest' is intentional, as it may reduce test coverage compared to running './gradlew test'.
run: ./gradlew testDebugUnitTest
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on improving code quality by updating the test command used in the Android workflow.
- Changed the test command from "./gradlew test" to "./gradlew testDebugUnitTest" to specifically run debug unit tests.
Files not reviewed (19)
- .editorconfig: Language not supported
- app/build.gradle.kts: Language not supported
- app/src/androidTest/java/com/pouyaheydari/androidappupdater/ExampleInstrumentedTest.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/ui/compose/theme/Color.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/ui/compose/theme/Theme.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/utils/GetUpdaterDSLStoreList.kt: Language not supported
- app/src/main/java/com/pouyaheydari/androidappupdater/utils/GetUpdaterNormalStoreList.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/android/MainActivity.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/ComposeSampleActivity.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/theme/Theme.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/ui/compose/theme/Type.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/ComposePreviewData.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/Constants.kt: Language not supported
- app/src/main/java/com/pouyaheydari/appupdater/demo/utils/DSLPreviewData.kt: Language not supported
- app/src/main/res/layout/activity_main.xml: Language not supported
- app/src/main/res/values/strings.xml: Language not supported
- app/src/main/res/values/styles.xml: Language not supported
- appupdater/build.gradle.kts: Language not supported
- appupdater/gradle.properties: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/android.yml:26
- [nitpick] Verify that switching to 'testDebugUnitTest' meets your intended testing scope; it may exclude other tests that './gradlew test' previously covered.
run: ./gradlew testDebugUnitTest
added 24 commits
March 30, 2025 17:46
…n into the core module
…ies to separate concerns
…o not depend on data
… boolean to indicate if the download is in progress or not
…g failed to notify the caller after the first interaction
HeyPouya
force-pushed
the
refactor/improve-code-quality
branch
from
150742e to
24836ab
Compare
HeyPouya
force-pushed
the
refactor/improve-code-quality
branch
from
f2023e2 to
eb66036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the code quality.