tweak: add cancel button to deploy dev center #1243
Conversation
|
|
| @@ -1074,101 +1075,7 @@ async function edit_app_section(cur_app_name, tab = 'deploy') { | |||
| // Focus on the first input | |||
| $('#edit-app-title').focus(); | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Can you add a comment about why this section of code was removed?
| @@ -31,6 +31,9 @@ let dropped_items; | |||
| let search_query; | |||
| let originalValues = {}; | |||
|
|
|||
| // At the top of your file, add a global variable to track deployment cancellation | |||
| let globalDeploymentCancelled = false; | |||
There was a problem hiding this comment.
We can probably just call this deploymentCancelled, since there's no "local deployment" option in the dev center.
|
Hello again, please correct me if I'm wrong but - upon manual and further review - cancelling doesn't really do anything, does it? It seems to me it just gives the user the illusion that something is being cancelled but deployment continues as normal. This could still be helpful since it allows the user to start another deployment again quickly if they made a mistake, but that might actually cause issues if there's already a concurrent deployment happening that they don't know about. |
Created a cancel button.
Made it cancel deployments.
Issue #1135