dev: get system user from SUService in AppIconService#2601
Open
KernelDeimos wants to merge 2 commits intomainfrom
Open
dev: get system user from SUService in AppIconService#2601KernelDeimos wants to merge 2 commits intomainfrom
KernelDeimos wants to merge 2 commits intomainfrom
Conversation
KernelDeimos
force-pushed
the
eric/26343_system-user-from-service
branch
from
fa74af2 to
b1a4e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small first-boot-time optimization. The optimization itself doesn't matter (first boot is fast enough) - I just want SUService being used here so that if somebody uses this as a reference on how to get the system user they have the correct approach. Using SUService is better because the system user does not change and we never need to fetch it from the database after boot.