Prevent arrow conversion to emoji; fix alignment of ticket elements #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grablair
changed the title
daveearley
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Thanks for this! I'd suggest using the right chevron icon, as it's more sleek and in keeping with other icons used in the app.
frontend/src/components/routes/ticket-widget/SelectTickets/index.tsx
Outdated
Show resolved
Hide resolved
|
Ah yeah that'll be much better. I'll get that change in tomorrow (PDT). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Safari (on iPhone), the right arrow is being converted to a ➡️ emoji, which is not desirable (FWIW, the down arrow is fine 🤷🏻♂️).
This changes the arrows from unicode arrows to an Icon, which also animates as the tickets open / close.
Also, fixes the inverted boolean logic around
ticketIsCollapsed. Same exact functionality, I just had the boolean logic backwards on all of it.Also, better aligns all the elements in the ticket title button.
Also fixes some alignment of ticket elements to ensure that the ticket counter is always on the right. If wrapping is necessary, the name of the tier should wrap.
BEFORE:
AFTER:
Checklist
Thank you for your contribution! 🎉