-
Notifications
You must be signed in to change notification settings - Fork 199
don't depend on coq stdlib #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm curious why the dependency information will be listed in two files (coq-hott.opam and coq-hott.opam.template) and is slightly different in the two places, with dune omitted in the former. |
|
Also, is this related to #2290? |
|
@jdchristensen Yes, I am attempting to get this to build with 9.1. The We are in a bit of a blind spot when it comes to Rocq development. We are one of the very few users of dune and of |
The |
Signed-off-by: Ali Caglayan <[email protected]>
|
@jdchristensen I forgot to do |
Does it make sense to commit a generated file? I guess it means that others don't need to run the generate script, but it also means that one has to remember to generate before committing. |
|
@jdchristensen We've been generating this file for a while with no problems. The only difference is the |
|
If everything is working as it should, then yes it is not needed any longer. |
|
Ok, I'll close this then. |
|
It seems like this is still useful. Can we just merge it as is? I'll reopen. |
| depends: [ | ||
| [ "dune" {>= "3.13"} ] | ||
| [ "coq" {>= "8.19.0" & < "9~"} ] | | ||
| [ "coq-core" {>= "9.0"} ] | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@Alizter @proux01 I tested a variant of this, and was not able to build Coq-HoTT using coq-core 9.0. As Ali had mentioned, there is an error involving in the coq-hott.opam file, which I found to be the most readable option, and which has the desired effect. The full set of steps I used and the error messages are below. So unless there is an easy workaround, I think we'll have to use something like (untested). Click to show |
|
That looks fine to me. Thanks for taking this on. |
|
@Alizter Do you know what's going on with the CI / install job that is taking more than an hour? It's sitting there printing out sha hashes. |
|
@Alizter Also, should we update rocq-prover/opam#3522 to avoid depending on the Coq stdlib? Or will that not matter for the context in which that .opam file is used? |
|
I've cancelled the CI job since it's just wasting CPU time. And I've restarted all jobs to see if the issue was just a temporary glitch. |
|
That CI glitch went away, so I'm merging. The only question that remains is the one about updating rocq-prover/opam#3522 |
|
@Alizter Oh, another question I just remembered: this version of the PR dropped the "odoc" dependency. Is that correct? I don't know what it is or whether we should be depending on it. |
|
@jdchristensen That's a default from dune for ocaml projects nothing to worry about. |
I think it's wort updating it in any case, the least unused dependencies the better. |
|
Done: rocq-prover/opam#3525 |
|
Thanks, @proux01 ! |
We use the
.opam.templatefeature of dune to get these weird dependency constrains in #2284.This will probably have breakages in Contrib which I will fix by disabling what we don't really need.