Add transport lemmas for morphisms to Category/Core #2299
Merged
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move transport lemmas from separate file to Core.v per PR HoTT#2298 review - @jdchristensen Changes: - Add transport_compose_morphism and transport_compose_both_inverse to Category/Core.v - Remove TransportMorphisms.v from Additive folder - Use Definition with pattern matching instead of Lemma with destruct - Drop redundant lemmas (moveL_transport_V already exists) Extracted from stable categories formalization (PR HoTT#2288). Tested with: make -f Makefile.coq
theories/Categories/Category/Core.v
Outdated
| (g o transport (fun U => morphism C U Y) p f)%morphism | ||
| := match p with idpath => idpath end. | ||
|
|
||
| (** Composing transported morphisms along inverse paths. *) |
Collaborator
There was a problem hiding this comment.
In the other PR, I had a suggestion about this comment. And now I realize that the name of this lemma also mentions "inverse", so should be changed.
Contributor
Author
There was a problem hiding this comment.
Thank you for reviewing. I am going to change it to transport_compose_middle - please let me know if you think a different one is more appropriate.
Move parameter to previous line to keep near 80 character limit per HoTT style guide. Co-authored-by: Dan Christensen <[email protected]>
Move parameter to previous line to keep near 80 character limit per HoTT style guide. Co-authored-by: Dan Christensen <[email protected]>
The definition doesn't involve inverse paths, just transporting the middle object in a composition chain. Updated comment and name.
Contributor
Author
|
@jdchristensen Feedback addressed:
|
jdchristensen
approved these changes
Jul 14, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move transport lemmas from separate file to Core.v per PR #2298 review - @jdchristensen
Changes:
Extracted from stable categories formalization (PR #2288). Tested with: make -f Makefile.coq