Overlay for PR#21164 #2317
Closed
Overlay for PR#21164 #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the link to the Rocq PR: rocq-prover/rocq#21164 Unfortunately, neither this PR nor that PR say what that PR does... @tabareau , can you explain? |
theories/Basics/Trunc.v
Outdated
Comment on lines
423
to
424
| (* This hint is required to be able to use cumulativity of inductive types *) | ||
| (* together with first-order approximation for polymorphic hints. *) |
There was a problem hiding this comment.
I don't know what "first-order approximation" means in this context.
(Also, minor point, but in Coq-HoTT comments are written as a single comment with no line breaks.)
There was a problem hiding this comment.
Suggested change
| (* This hint is required to be able to use cumulativity of inductive types *) | |
| (* together with first-order approximation for polymorphic hints. *) | |
| (* This hint is required to be able to use cumulativity of inductive types together with first-order approximation for polymorphic hints. *) |
tabareau
force-pushed
the
hint-refresh-firstorder-approx
branch
from
575f308 to
f0d5996
Compare
you are right, @ppedrot will explain on the PR. |
|
Closed in favour of #2318 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.