-
Notifications
You must be signed in to change notification settings - Fork 199
Miscellaneous small changes #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Otherwise this looks good to me! |
|
I'll merge once the CI is done, unless @Alizter also wants to take a look. |
|
I would like to take a look tomorrow at the weekend if that's no problem. |
|
@Alizter Any idea what's up with the failure of coqchk? All I did is remove a comment when I force pushed, and I'm pretty sure all jobs succeeded when I first created this PR. |
|
I'm not certain. Since it's only dev that is failing it could be an upstream issue so that would have to be checked. I can take a look tomorrow if it persists. |
|
I re-ran the jobs, and there was no error this time, so it was just a temporary glitch. |
|
|
||
| (** This file contains all the tweaks and settings we make to Coq. *) | ||
|
|
||
| (** ** Warnings *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I kept this as the natural place to include warnings. I don't feel strongly about keeping it but just FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what I thought, but we may as well keep things simple until we need them.
I've accumulated a bunch of small things. Each commit is independent and affects only one file, so they can be reviewed separately or together.