Skip to content

Conversation

@jdchristensen
Copy link
Collaborator

I've accumulated a bunch of small things. Each commit is independent and affects only one file, so they can be reviewed separately or together.

@ThomatoTomato
Copy link
Collaborator

Otherwise this looks good to me!

@jdchristensen
Copy link
Collaborator Author

I'll merge once the CI is done, unless @Alizter also wants to take a look.

@Alizter
Copy link
Collaborator

Alizter commented Oct 31, 2025

I would like to take a look tomorrow at the weekend if that's no problem.

@jdchristensen
Copy link
Collaborator Author

@Alizter Any idea what's up with the failure of coqchk? All I did is remove a comment when I force pushed, and I'm pretty sure all jobs succeeded when I first created this PR.

@Alizter
Copy link
Collaborator

Alizter commented Oct 31, 2025

I'm not certain. Since it's only dev that is failing it could be an upstream issue so that would have to be checked. I can take a look tomorrow if it persists.

@jdchristensen
Copy link
Collaborator Author

I re-ran the jobs, and there was no error this time, so it was just a temporary glitch.


(** This file contains all the tweaks and settings we make to Coq. *)

(** ** Warnings *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I kept this as the natural place to include warnings. I don't feel strongly about keeping it but just FYI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I thought, but we may as well keep things simple until we need them.

@jdchristensen jdchristensen merged commit 5c938e4 into HoTT:master Oct 31, 2025
64 of 66 checks passed
@jdchristensen jdchristensen deleted the misc branch October 31, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants