Skip to content

🩹Fix missing default values of _version and _typ #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 31, 2024
Merged

🩹Fix missing default values of _version and _typ #206

merged 10 commits into from
Jul 31, 2024

Conversation

lord-haffi
Copy link
Collaborator

@lord-haffi lord-haffi commented Jul 19, 2024 •
edited
Loading

@lord-haffi lord-haffi self-assigned this Jul 19, 2024
@lord-haffi lord-haffi requested a review from hf-sheese July 19, 2024 11:19
@lord-haffi
Copy link
Collaborator Author

Unfortunately, there are problems when building the docs. But since it is currently not used anywhere, I decided to unblock @hf-sheese work and changed the workflow to ignore these warnings.

@hf-sheese hf-sheese merged commit 87e5648 into main Jul 31, 2024
15 checks passed
@hf-sheese hf-sheese deleted the fix_default_value branch July 31, 2024 05:31
@lord-haffi
Copy link
Collaborator Author

lord-haffi commented Jul 31, 2024 •
edited
Loading

Unfortunately, there are problems when building the docs. But since it is currently not used anywhere, I decided to unblock @hf-sheese work and changed the workflow to ignore these warnings.

To reproduce, change the sphinx commands in tox.ini by adding the option -W to treat warnings as errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-sheese hf-sheese hf-sheese approved these changes

Assignees

@lord-haffi lord-haffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lord-haffi @hf-sheese