Support servant-0.20 and GHC 9.6 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michivi
reviewed
Dec 7, 2023
turboMaCk
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
LGTM
I agree with decision to drop support for older snapshots. Since there are no breaking API changes it should be seamless to just upgrade library together with snapshot. I don't think doping these old snapshots will add too much friction for down stream projects.
jhrcek
commented
Dec 7, 2023
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ | |||
| `servant-hmac-auth` uses [PVP Versioning][1]. | |||
| The change log is available [on GitHub][2]. | |||
|
|
|||
| ## 0.1.6 - TBD | |||
There was a problem hiding this comment.
Let me know if you're fine with releasing the package as is and I'll bump the version in cabal file and upload it to hackage.
jhrcek
commented
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate attempt to apply changes from #64 without dropping support for servant-0.19
Questions. Are we ok with dropping support for ghc 8.10?
Seems to me like most of the world already upgraded to 9+.
And if there are internal projects depending on it, they can keep using previous versions of this package.