-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
feat: add appimage support for linux #20334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c91f2f7
to
caba75a
Compare
Need CI before this PR is merged. Where are the app images installed and is that an expected/sensible location? Maybe we should reuse |
I considered it, but deemed it too confusing. Especially with it not working on macOS.
In |
@SMillerDev sounds good 👍🏻 |
I'm also considering adding a desktop file for these so the various Linux systems can pick it up easily. Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This is waiting for the following pieces:
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Not stale, but it is waiting for Linux CI for casks, and that's not going as fast as I'd like. So help would be much appreciated. |
Okay, now that Linux CI for casks is merged I'm planning to:
|
caba75a
to
85b07ae
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This adds support for the first linux-only cask stanza:
app_image
.We should probably add CI for Linux casks, but haven't been able to get that working yet.