Skip to content

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Oct 11, 2025

…ed_as_dependency and installed_on_request

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

solve the comment # TODO: change this to always return a boolean

@hyuraku hyuraku force-pushed the tab-install-status-type-safety branch from e76825a to 8d506bc Compare October 12, 2025 09:52
@hyuraku hyuraku force-pushed the tab-install-status-type-safety branch from 7463539 to 542b11b Compare October 13, 2025 12:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few tweaks.

Comment on lines +559 to +566

def installed_on_request_present?
@installed_on_request_present
end

def installed_as_dependency_present?
@installed_as_dependency_present
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def installed_on_request_present?
@installed_on_request_present
end
def installed_as_dependency_present?
@installed_as_dependency_present
end
sig { returns(T::Boolean) }
def installed_on_request_present? = @installed_on_request_present
sig { returns(T::Boolean) }
def installed_as_dependency_present? = @installed_as_dependency_present

Comment on lines +65 to +66
f.any_installed_keg&.tab&.installed_on_request == false &&
f.any_installed_keg&.tab&.installed_on_request_present?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f.any_installed_keg&.tab&.installed_on_request == false &&
f.any_installed_keg&.tab&.installed_on_request_present?
tab = f.any_installed_keg&.tab
next unless tab
next unless tab.installed_on_request_present?
tab.installed_on_request == false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants