Skip to content

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sometimes only one type of system's bottles are required to default prefix. be in the . We should allow pour_bottle? to be added to on_system blocks in order to only restrict bottle pours on those systems.

Fixes https://github.com/orgs/Homebrew/discussions/6468.

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 17:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR allows the pour_bottle? method to be used within on_system blocks in Homebrew formulas. This change enables more granular control over bottle installations by allowing restriction of bottle pours to specific systems only.

  • Added pour_bottle? to the list of allowed methods within on_system blocks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 9faa9b0 Oct 16, 2025
37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the on_system_pour_bottle branch October 16, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants