Skip to content

Conversation

@loplex
Copy link
Contributor

@loplex loplex commented Dec 15, 2025

The cleanup logic was attempting to use pgrep with the -9 flag, which is invalid. This switches the command to pkill to correctly send SIGKILL to remaining child processes.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

The cleanup logic was attempting to use `pgrep` with the -9 flag, which is invalid.
This switches the command to `pkill` to correctly send SIGKILL to remaining child processes.

Signed-off-by: Martin Lopatář <[email protected]>
Copilot AI review requested due to automatic review settings December 15, 2025 23:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the test cleanup logic where the wrong command was being used to kill remaining child processes. The code was attempting to use pgrep -9, but pgrep is a process search tool that doesn't accept signal flags like -9 (SIGKILL). The fix correctly changes this to pkill -9, which properly sends SIGKILL to terminate any remaining child processes after the initial SIGTERM attempt.

Key Changes:

  • Corrected command from pgrep to pkill in the cleanup logic to properly send SIGKILL signal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants