Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Dec 16, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Part of

Copilot AI review requested due to automatic review settings December 16, 2025 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates Library/Homebrew/debrew.rb from typed: true to typed: strict Sorbet mode, which is part of the ongoing effort tracked in issue #17297. The changes add comprehensive type signatures to satisfy Sorbet's strict typing requirements while maintaining the existing functionality of the debugging helper module for Homebrew formulae.

Key Changes:

  • Upgraded Sorbet typing level from typed: true to typed: strict
  • Added type signatures for all methods in the Debrew::Formula module and Debrew::Menu class
  • Converted Entry from a regular Ruby Struct to a T::Struct for better type safety
  • Added proper type annotations for module-level instance variables and class methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants