This repository was archived by the owner on Oct 15, 2025. It is now read-only.
stella: revert Convert stringstream::view() to stringstream::str() for ventura builds
#977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licable." Signed-off-by: Rui Chen <[email protected]>
chenrui333
changed the title
Convert stringstream::view() to stringstream::str() for ventura builds
MikeMcQuaid
approved these changes
Jan 24, 2025
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good as long as merged upstream!
Member
Author
|
upstream is not quite responsive, since we have already used the patch for the formula, I am going to merge it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert stringstream::view()tostringstream::str()for ventura builds stella-emu/stella#1064