Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farrago, fission: update livecheck #207042

Merged
merged 2 commits into from
Apr 2, 2025
Merged

farrago, fission: update livecheck #207042

merged 2 commits into from
Apr 2, 2025

Conversation

khipp
Copy link
Member

@khipp khipp commented Mar 31, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Neither of these casks supports legacy versions, so we can set the system query parameter to a fixed value to return consistent results.

Related to #204987

@khipp khipp added the livecheck Issues or PRs related to livecheck label Mar 31, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks @khipp!

@p-linnane p-linnane merged commit 55cb9b9 into master Apr 2, 2025
13 checks passed
@p-linnane p-linnane deleted the update-rogueamoeba branch April 2, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants