Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.22.0 #157782

Merged
merged 4 commits into from
Feb 15, 2024
Merged

go 1.22.0 #157782

merged 4 commits into from
Feb 15, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Dec 19, 2023

See

Issues:


Test buid run logs:


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. automerge-skip `brew pr-automerge` will skip this pull request labels Dec 19, 2023
@fxcoudert fxcoudert added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Dec 19, 2023
@chenrui333
Copy link
Member

looks like garble does not work with go1.22

@p-linnane p-linnane added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Dec 20, 2023
@p-linnane
Copy link
Member

@stefanb Thank you for always working on these major Go release PR's. It's very appreciated!

@chenrui333
Copy link
Member

since garble is known issue, I would suggest just deprecate it for the sake of pre-release testing.

@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 20, 2023
@stefanb stefanb force-pushed the go1.22 branch 3 times, most recently from ef34b52 to 87cf01d Compare December 21, 2023 05:46
@stefanb
Copy link
Member Author

stefanb commented Dec 21, 2023

since garble is known issue, I would suggest just deprecate it for the sake of pre-release testing.

@chenrui333, I have removed garble revision bump for the time being since we have isolated the problem and you have created the upstream issue burrowers/garble#820 and deprecation did not work for some reason.

@stefanb
Copy link
Member Author

stefanb commented Dec 28, 2023

Many formulae seem to have a problem with webrick during test. Not sure if this is a problem of the formula or a ruby/homebrew testing framework.

  • emp
  • toxiproxy
  • trojan-go

@chenrui333 chenrui333 removed CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-livecheck Pass --skip-livecheck to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 15, 2024
Merged via the queue into Homebrew:master with commit b3e24f7 Feb 15, 2024
20 checks passed
@stefanb stefanb deleted the go1.22 branch February 15, 2024 12:33
@julienschmidt
Copy link

What would we have to do to get a new version of golangci-lint built with the now available Go 1.22?
The current version built with Go 1.21.7 is unfortunately unable to handle Go 1.22 syntax.
As far as I can tell, no changes to the formula are necessary, it just needs to be rebuilt.

@Porkepix
Copy link
Contributor

Porkepix commented Feb 15, 2024

What would we have to do to get a new version of golangci-lint built with the now available Go 1.22? The current version built with Go 1.21.7 is unfortunately unable to handle Go 1.22 syntax. As far as I can tell, no changes to the formula are necessary, it just needs to be rebuilt.

Either wait for a new version on their side if it comes quickly, or submit a revision bump PR.

EDIT: Third option is to have bottles rebuilt and just that, but I'm unsure how it's done, should ask maintainers.

Difference is that a revision bump would be considered as an updated for everyone and force an upgrade to everyone on brew upgrade, while a simple bottle rebuild would only benefit to people upgrading after it or to those forcing a reinstall.

@butuzov
Copy link
Contributor

butuzov commented Feb 15, 2024

It's (new version) going to be released soon.

stefanb added a commit to stefanb/homebrew-core that referenced this pull request Feb 15, 2024
Rebuild with Go 1.22 as a follow-up to:
* Homebrew#157782
@chenrui333
Copy link
Member

chenrui333 commented Feb 15, 2024

What would we have to do to get a new version of golangci-lint built with the now available Go 1.22?

yeah, we should revision bump it (I actually noted above.)


would be covered by #162838

chenrui333 pushed a commit to stefanb/homebrew-core that referenced this pull request Feb 15, 2024
stefanb added a commit to stefanb/homebrew-core that referenced this pull request Feb 16, 2024
trajan0x added a commit to synapsecns/sanguine that referenced this pull request Feb 25, 2024
trajan0x added a commit to synapsecns/sanguine that referenced this pull request Feb 25, 2024
@trajan0x
Copy link

re: grafana-agent looks like v40 is out and that can be checked off (see changelog)

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.