Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kertish-dos: renamed the formula #202269

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

freakmaxi
Copy link
Contributor

  • [ x ] Have you followed the guidelines for contributing?
  • [ x ] Have you ensured that your commits follow the commit style guide?
  • [ x ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ x ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ x ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ x ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 23, 2024
@freakmaxi
Copy link
Contributor Author

Hello,

According to the instruction in the following URL https://docs.brew.sh/Rename-A-Formula brew audit --strict should pass. It passes, but here, it considers that it is a new formula and there shouldn't be bottle do section in the formula.

Should I remove that section and retry or Should I use brew bump-formula-pr?

@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. ready to merge PR can be merged once CI is green and removed ready to merge PR can be merged once CI is green CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Dec 23, 2024
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 23, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Dec 24, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 24, 2024
Merged via the queue into Homebrew:master with commit 97e20e3 Dec 24, 2024
15 checks passed
@chenrui333
Copy link
Member

Thanks @freakMax!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants