Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asdf: disable cgo for linux to improve portability #210601

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

andrecloutier
Copy link
Contributor

@andrecloutier andrecloutier commented Mar 12, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Improves portability for linux builds in particular.

Fixes: asdf-vm/asdf#1992

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Mar 12, 2025
@andrecloutier andrecloutier marked this pull request as ready for review March 12, 2025 02:27
@chenrui333
Copy link
Member

@chenrui333 chenrui333 changed the title asdf: disable cgo to improve portability asdf: disable cgo for linux to improve portability Mar 12, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 12, 2025
@BrewTestBot BrewTestBot enabled auto-merge March 12, 2025 19:16
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 12, 2025
Merged via the queue into Homebrew:master with commit 237bfb5 Mar 12, 2025
15 checks passed
@andrecloutier andrecloutier deleted the patch-2 branch March 12, 2025 20:44
@Stratus3D
Copy link
Contributor

Thank you for this @andrecloutier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unable to run asdf v16 on RHEL OS < 9
5 participants