Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aptly: remove gopath #47626

Closed
wants to merge 2 commits into from
Closed

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 8, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Remove gopath as formula has moved to go modules.

Relates to #47627

@chenrui333 chenrui333 closed this Dec 9, 2019
@chenrui333
Copy link
Member Author

I will need to work a little bit on this offline.

@alebcay
Copy link
Member

alebcay commented Dec 9, 2019

This will also address an entry in #45514 once this is merged.

@chenrui333
Copy link
Member Author

Cool, thanks for the cross-reference!

@lock lock bot added the outdated PR was locked due to age label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@chenrui333 chenrui333 deleted the aptly-remove-gopath branch December 18, 2022 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants