Check language of VOT document #1168
Draft
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an English translation isn’t yet available, requesting the English translation will return the French original. This checks whether the returned document actually is the English version. If not, it raises a `NoWorkingUrlError` exception, which will be treated in the same way as if the EP website had returned a 404 (i.e. the scraper will be retried later). Fixes #1167
tillprochaska
force-pushed
the
vot-list-check-language
branch
from
bdf7738 to
62e2064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an English translation isn’t yet available, requesting the English translation will return the French original. This checks whether the returned document actually is the English version. If not, it raises a
NoWorkingUrlErrorexception, which will be treated in the same way as if the EP website had returned a 404 (i.e. the scraper will be retried later).Fixes #1167
This is a draft PR for now, because I do need to verify whether the returned document actually includes the correct language code. See issue linked above for details.