Update hs init and hs auth for config revamp#1448
Closed
camden11 wants to merge 2 commits intoconfig-revamp-mainfrom
Closed
Update hs init and hs auth for config revamp#1448camden11 wants to merge 2 commits intoconfig-revamp-mainfrom
camden11 wants to merge 2 commits intoconfig-revamp-mainfrom
Conversation
camden11
requested review from
brandenrodgers,
joe-yeager and
kemmerle
as code owners
camden11
commented
Apr 15, 2025
| logger.error(i18n(`${i18nKey}.errors.noConfigFileFound`)); | ||
| process.exit(EXIT_CODES.ERROR); | ||
| } | ||
| const configPath = getConfigFilePath(); |
Contributor
Author
There was a problem hiding this comment.
No longer need to manually error - getConfigFilePath will throw if there's no config
camden11
commented
Apr 15, 2025
| ); | ||
| process.exit(EXIT_CODES.ERROR); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Figured we could simplify this logic a bit. If any config file exists (which we check for above), exit regardless of whether its local or global. I updated the error message to make it make sense for both cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
This updates
hs initandhs auth(and also app migrate) to work with the new config changes.Who to Notify
@brandenrodgers @kemmerle @joe-yeager