-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing link warning #6532
Closed
HussainAther
wants to merge
1,250
commits into
Hubs-Foundation:fix/chat-logs-padding
from
HussainAther:fix-missing-link-warning
Closed
Fix missing link warning #6532
Changes from 1 commit
Commits
Show all changes
1250 commits
Select commit
Hold shift + click to select a range
3e065cc
Merge pull request #6323 from mozilla/bitecs-object-spawner-permissio…
keianhzo 52de272
Merge pull request #6324 from mozilla/bitecs-object-menu-spawn-check
keianhzo 3e139db
Merge pull request #6327 from mozilla/bitecs-media-link-fix
keianhzo 97b9686
Merge pull request #6320 from mozilla/bitecs-nav-mesh-visibility-fix
keianhzo 3eb8c65
Show avatar menu when inspecting
keianhzo e7c37fc
Fix avatar hiding
keianhzo a214c39
Hide inspect prev/next menu for avatars
keianhzo 3b6d99a
Merge pull request #6326 from mozilla/bitecs-nav-mesh-update
keianhzo ec3fd55
Make nav mesh invisible at load time
keianhzo 6d63790
Better align nav-mesh queries
keianhzo 1a64e83
Merge pull request #6340 from mozilla/bitecs-nav-mesh-fixes
keianhzo 5711df6
Merge pull request #6328 from mozilla/bitecs-avatar-menu-fix
keianhzo 54c5e56
Enforce WebAudio params within limits
keianhzo ef4fabe
catch resolveUrl exceptions
keianhzo 50736ed
Merge pull request #6341 from mozilla/bitecs-type-checking
keianhzo 70be1cf
Add a raycastable menu background
keianhzo 67f14d4
Add pinning support
keianhzo 979803c
Re-enable conditional signing for pinning
keianhzo 591062d
Add explanation
keianhzo 3c9cbc5
Remove promotional tokes dependency
keianhzo 9def2d5
Fix comment
keianhzo c2bc0f1
Remove unused imports
keianhzo 47fff87
Revert latest changes
keianhzo 2c75ca2
Add new loader toggle UI in room settings
takahirox b9f9077
Merge pull request #6354 from mozilla/ToggleNewLoaderUI
takahirox 9c8c2b3
Reload when the new loader is toggled
takahirox d71e52e
Merge pull request #6355 from mozilla/ReloadIfNewLoaderIsToggled
takahirox 6242146
Rename New Loader
takahirox ec7e802
Recenter the object menu every frame
keianhzo b063bf4
Fix menu buttons visibility to account for pinning
keianhzo e9e6cf1
Fix grabbing to account for pinning perms
keianhzo 8e2e7e0
Remove promotion token
keianhzo 8058e3a
Merge pull request #6356 from mozilla/RenameNewLoader
takahirox 855d396
Fix Browse button layout
takahirox 93d2537
Merge pull request #6361 from mozilla/FixBrowseButton
takahirox f2f62b9
Fix spawned media menu target resolution
keianhzo bae070b
Merge pull request #6363 from mozilla/object-menu-link-crash
keianhzo 2ac1b40
Fixes physics and positioning issues with media loader
keianhzo 0c3fd50
First pass additions to media-frames for scale and alignment control
rawnsley c586250
Merge pull request #6351 from mozilla/bitecs-menu-background
keianhzo 84f9da3
Fix object-menu rendering transparency issues
keianhzo 000ffa1
Merge pull request #6375 from mozilla/bitecs-fix-menu-transparency
keianhzo bb4651b
Adjustments for special case of video in media frames
rawnsley e824392
Consider non-unit scaling and media frame bound sizes
rawnsley 03e5a30
Merge branch 'master' into media-frame-alignment
rawnsley f971cb0
separate animate and physics for reusability
keianhzo 022a200
Spawner fixes
keianhzo f704ed2
Support for creating a room with parameters using the "new" flag
keianhzo 1c0b4f4
Exclude the "new" flag
keianhzo b37c6ba
Merge pull request #6383 from mozilla/new-room-params-support
keianhzo 192cae9
Check if nav mesh mesh object exists
keianhzo 982610d
Check if coneOuterGain is defined before clamping its value
keianhzo 56bfe7e
Merge pull request #6384 from mozilla/nav-mesh-exist-check
keianhzo 41cb00a
Merge pull request #6385 from mozilla/check-undefined-coneoutergain
keianhzo 9e214de
Disallow vr_entry_type room limit override
keianhzo c9d2060
Merge pull request #6386 from mozilla/entry-type-room-limit-override-fix
keianhzo e61df77
Merge pull request #6371 from mozilla/bitecs-media-loading-updates
keianhzo d6ccd7e
Fix scalar calculation
keianhzo d2ea71e
Merge pull request #6387 from mozilla:bitecs-fix-scalar-calc
keianhzo 36a06e5
Check if channel has been created before updating the object menu
keianhzo 6467b94
Merge pull request #6380 from mozilla/bitecs-spawner-transform-animat…
keianhzo 4513538
Fix MediaContent bounds
keianhzo e6388e3
Merge pull request #6388 from mozilla/bitecs-fix-media-content-bounds
keianhzo a3b24f6
Fixed lint errors
rawnsley fbf5d20
Merge pull request #6377 from LearnHub/media-frame-alignment
keianhzo dfa31bc
Post Media Frame Updates
keianhzo 93116bd
Merge pull request #6389 from mozilla/bitecs-post-media-frame-alignme…
keianhzo 17eac2a
Merge pull request #6287 from mozilla/bitecs-object-list-pinning
keianhzo daf7ffc
Local media new loader issues fix
keianhzo e741938
Merge pull request #6390 from mozilla/bitecs-post-merge-fixes
keianhzo 9b72fd9
Media loading scale issue fix
keianhzo 860435e
Merge pull request #6391 from mozilla/bitecs-media-loading-scale-fix
keianhzo 6c07f38
Add object menu link if image controls are enabled
keianhzo ffe75f9
null check for link source
keianhzo b746f90
Look for the holdable media root when grabbing an object
keianhzo 230af63
Update video menu layout
keianhzo 8895b7b
Merge pull request #6394 from mozilla/bitecs-video-menu-updates
keianhzo 13d7597
Merge pull request #6393 from mozilla/bitecs-media-link-hold-bug
keianhzo 4ef68d2
Merge pull request #6392 from mozilla/bitecs-image-controls-link-menu
keianhzo c7bc8af
Use MediaLoader instead of MediaContentBound to find the loader
keianhzo ad05d74
Fix static media pinnable state
keianhzo f863046
Fix deletable
keianhzo 009b477
Fix aframe media loading
keianhzo 552ed78
Remove unused import
keianhzo 472c236
Merge pull request #6408 from mozilla/bitecs-static-media-pinnable
keianhzo 31b1f50
Merge pull request #6413 from mozilla/bitecs-aframe-media-fix
keianhzo 08c70ce
Default to empty if scene load fails
keianhzo d999855
Merge pull request #6415 from mozilla/default-to-empty-if-scene-load-…
keianhzo 0cc0dd8
update lib-hubs to latest commit
kfarr 80c1383
Expose reticulum url
keianhzo 0e5ec47
Merge pull request #6425 from kfarr/cherry-pick-update-lib-hubs
keianhzo ee6d599
Merge pull request #6257 from paliacci/master
keianhzo c93db3d
Merge pull request #6238 from LorenzoVonMatterhom/master
keianhzo 9161d6f
Remove comment from it locale
keianhzo 0bc96b6
Update string
keianhzo 9fabfc7
Merge pull request #6427 from mozilla/it-localization-fix
keianhzo a24ba4f
Add Italian to the available language list
keianhzo 793de26
Merge pull request #6429 from mozilla/add-italian
keianhzo 69ec7be
Compat layer to fully support pen in bitECS
keianhzo 73b6f2c
Merge pull request #6424 from mozilla/expose-ret-url
keianhzo a303043
BitECS drop button
keianhzo 32cbf34
Prevent camera scaling
keianhzo 4804f77
Merge pull request #6444 from mozilla/prevent-camera-scaling
keianhzo c16e92f
Merge pull request #6434 from mozilla/pen-bitecs-interactables-compat
keianhzo 8d996ff
Bit media SFX
keianhzo e9ac511
Bit button SFX
keianhzo c3ed128
Mic toggle SFX
keianhzo c003c76
Merge pull request #6436 from mozilla/bit-sfx-update
keianhzo bf62039
BitECS hover visual effect
keianhzo d387b18
Merge pull request #6437 from mozilla/bit-hover-effect
keianhzo f8f4e6f
Limit hover effect to non pinned entities and frozen state
keianhzo 3509ac8
Merge pull request #6446 from mozilla/bitecs-pinned-not-hover-visuals
keianhzo 8ac0b72
Merge pull request #6442 from mozilla/bitecs-drop-button
keianhzo 15ad4de
BitECS Mirror Button
keianhzo 7333f4a
Mute source audio when linking audio media
keianhzo 8545126
Improve menu interaction
keianhzo 14afc90
Merge pull request #6443 from mozilla/bitecs-mirror-button
keianhzo baa50aa
Improve menu interaction
keianhzo 7299358
BitECS inspect button
keianhzo 8b17df2
Remove unwanted changes
keianhzo 4bfbcbd
Revert to using Deletable in ObjectMenu
keianhzo 3e17530
Fix inspecting focus issues
keianhzo 1f7c920
Merge pull request #6445 from mozilla/bitecs-inspect-button
keianhzo b0082b9
Disable the hover effect while in inspect mode
keianhzo 494b3bb
Merge pull request #6447 from mozilla/bitecs-improve-menu-interaction
keianhzo fead7c9
Merge pull request #6448 from mozilla/no-hover-effect-inspect
keianhzo aedfafa
Deselect objects when the object sidebar is closed
keianhzo bf4927c
Merge pull request #6449 from mozilla/inspect-fix-object-list-closed
keianhzo bb60afa
Handle inspected entity removal cases gracefully
keianhzo add9afa
Merge pull request #6450 from mozilla/bitecs-inspect-bug-fix
keianhzo 3cbd8f5
BitECS snap object menu support
keianhzo 862c74a
Do not show snap button for audio media
keianhzo 75efc61
Place snapped object around original
keianhzo ced6609
Merge pull request #6451 from mozilla/bitecs-snap-object-menu
keianhzo 2a38a13
Volume controls in the video menu
keianhzo 889701f
Check if current gain is undefined
keianhzo 8411cd7
Merge pull request #6452 from mozilla/bitecs-video-menu-volume
keianhzo c23df7c
BitECS object menu refresh button
keianhzo 35eb38e
Merge pull request #6453 from mozilla/bitecs-object-menu-refresh
keianhzo cba5e2b
Fix menus scale
keianhzo 22dd263
Merge pull request #6454 from mozilla/bitecs-menu-size-fix
keianhzo a53a4e4
Fix video controls visibility
keianhzo 83ac743
Scale only pdf and video menus
keianhzo 9315087
Merge pull request #6456 from mozilla/bitecs-scale-menu-only-pdf-video
keianhzo 14c3e35
Merge pull request #6455 from mozilla/bitecs-hide-audio-if-no-controls
keianhzo 6b94772
Fix spawned media sliding
keianhzo 852d3cb
Merge pull request #6457 from mozilla/bitecs-fix-loading-transition
keianhzo 4eca39b
Add unprivileged object menu and layout update
keianhzo fba1b4c
Merge pull request #6458 from mozilla/bitcs-unpriv-object-menu
keianhzo 9a68731
BitECS focus/track object menu support
keianhzo a088649
Merge pull request #6459 from mozilla/bitecs-object-menu-focus
keianhzo 928d14a
Fix position of inspect buttons when the object is droppable
keianhzo 4586072
Merge pull request #6460 from mozilla/bitecs-fix-object-menu-buttons-…
keianhzo f779a8e
Avoid crash when cloning Troika text
keianhzo 9ed5183
Merge pull request #6461 from mozilla/frame-preview-fixes
keianhzo 66896f6
Handle grab scaled object
keianhzo 0ee6757
Merge pull request #6462 from mozilla/bitecs-scale-grabbed
keianhzo af9c696
Force a matrix world update when audio is created
keianhzo a8208fc
Merge pull request #6463 from mozilla/invisible-audio-fix
keianhzo 0795abd
Fix avatar self inspection
keianhzo bf6ed63
Merge pull request #6469 from mozilla/bitecs-fix-inspect
keianhzo 3e56b44
Update SECURITY.md
keianhzo 190aca0
Merge pull request #6477 from mozilla/keianhzo-patch-1
keianhzo 12393a9
Fix pen VR
keianhzo cc3c62d
Remove unused imports
keianhzo 746413d
Merge pull request #6478 from mozilla/bitecs-fix-pen
keianhzo ec12e4c
Scene grabbables support
keianhzo ae050ee
Revert media collision mask
keianhzo c23b7d4
Add warning for negative scale when creating interactables bounds
keianhzo 4324d10
Merge pull request #6487 from mozilla/scene-grabbables
keianhzo eccb840
Initial add-ons API commit
keianhzo 4e69cb6
Try to get some more info about the build error
keianhzo 1b48d6e
Do not install dev dependencies in production
keianhzo 3cc6d09
Revert tests
keianhzo f3d84cc
organize types
keianhzo 4ff2d0e
Test
keianhzo 460930f
Omit dev packages when installing deps in production
keianhzo 3726836
Package lock update
keianhzo 2781f1f
Increase log level
keianhzo ca5a91e
Try --legacy-peer-deps
keianhzo 4a432f9
Use webpack in addons instead of tsup
keianhzo f0da86a
Revert docker image changes
keianhzo 174c6fa
Remove portals addon
keianhzo 56f6567
Update addon version
keianhzo f3d12c4
Update addons
keianhzo 2240897
BGs initial support
keianhzo 0956082
Packages updates
keianhzo 5920ae4
Better handle of bitECS/addons state
keianhzo fe03f9c
Add lost trigger collision group
keianhzo 4f4f186
Skip homepage when creating a new room
keianhzo 5beeac1
Update BGs add-on
keianhzo b16f757
Add-ons docs
keianhzo e03ce8b
Fix format
keianhzo 672c680
Fix image size
keianhzo 644d101
Restore dockerfile
keianhzo d616838
Add add-on preferences update support
keianhzo 129b460
Add post-processing addon
keianhzo 7c20ad5
Use legacy peers for storybook
keianhzo 905abd9
Pin addons versions
keianhzo 02255be
Update README.md
Jacob-Ervin c3f8f7a
Merge pull request #6491 from mozilla/Jacob-Ervin-patch-1
Jacob-Ervin c02bb8d
remove unnecessary legacy-peer-deps
keianhzo 5b9ce83
Fix admin store access
keianhzo bccf94d
Update admin store ref
keianhzo 064441a
Fix addon configuration
keianhzo a753cc1
Remove Mozilla references and links.
Exairnous 3414011
Remove Mozilla references from PROMOTION.md
Exairnous 5e74413
Remove or replace Mozilla branding images and videos.
Exairnous a86b8ec
Update the Invite Bot to Server link/button on the Discord page.
Exairnous a300df7
Fix formatting.
Exairnous ae02b3b
update locale and copy regarding Powered by "Mozilla Hub"
tksham 6b4a42e
update remaining local and link of hubsfoundation.org
tksham 5ee2350
Merge pull request #6494 from tksham/mozilla-branding-removal-1
Exairnous 699187a
Initialize transform matrix to avoid undefined index references
rawnsley 49fe109
Merge pull request #6495 from rawnsley/matrix-init-for-browser-freeze
Exairnous f3c685e
Merge pull request #6493 from Hubs-Foundation/mozilla-branding-removal-1
Exairnous daaae65
Use the Hubs Foundation's docker hub repository for building and push…
Exairnous 9357a37
Comment out the Smoke test section as the Hubs Foundation doesn't hav…
Exairnous 86378ea
Merge pull request #6498 from Hubs-Foundation/hubsfoundation-docker-r…
Exairnous 1567f22
Eliminates warnings by prettier and caniuse-lite
DougReeder 33ed11f
Merge pull request #6499 from DougReeder/eliminate-warnings
Exairnous 313e559
Invites & sharing Room URL use Web Share API if available
DougReeder 017a30a
Sharing invite: hostname is now always correct & l10n strings corrected
DougReeder 306ff67
Share Invitation incorporates text from configuration & option to sha…
DougReeder 98e85c4
Invite using Web Share API: hides "Share in English" when locale is E…
DougReeder 5098d29
Invite using Web Share API: improves German translation
DougReeder 730a9d2
Fixes lint complaints
DougReeder 95a08fc
Merge pull request #6508 from DougReeder/web-share-api
Exairnous fdd587c
Adds Share button to picture and video items in Chat
DougReeder 90f2b0e
Scene page: replaces 'Share on Twitter' w/ 'Share' (using Web Share API)
DougReeder c0adadd
Merge pull request #6511 from DougReeder/chat-share
Exairnous e5eb1a2
Merge pull request #6512 from DougReeder/scene-share
Exairnous 036565e
HUD Invite button: fixes by calling System Share API directly
DougReeder babb4a2
Merge pull request #6510 from DougReeder/vr-invite
Exairnous 0dabc28
Revert Scene grabbables support PR and fix the bugs caused by it
Exairnous 7615e93
Fixes layout bug in chat sidebar introduced by PR #6511
DougReeder 0bd77cb
Merge pull request #6516 from DougReeder/chat-bubble-fix
Exairnous 392782e
Merge branch 'master' into addons
Exairnous ec5835b
[Mozilla Branding Removal] Update dependency links
Exairnous b0c1a7a
Unpin addons versions
Exairnous 7a99b6f
Make dependency URL capitalization consistent
Exairnous be1d82d
Merge pull request #6515 from Hubs-Foundation/revert-scene-grabbables…
Exairnous e449f66
Merge branch 'master' into addons (likely breaks the branch)
Exairnous 348c602
Revert "Merge branch 'master' into addons (likely breaks the branch)"
Exairnous 9ffe97b
Partially fix rotating and scaling via the spacebar menu buttons
Exairnous 8d28f61
Resolved merge conflict in package-lock.json
HussainAther 6ab775d
Resolved merge conflicts in package-lock.json
HussainAther 50d13ce
safeguard incldued
HussainAther 4f60634
Improved link validation and debugging in gltf-model-plus.js
HussainAther 1bde44b
indentation fix
HussainAther File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but please fix the indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, how exact should I fix it?
EDIT: Ok, I see it now. Thanks. It should be just be two spaces.