Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing link warning #6532

Closed
Changes from 1 commit
Commits
Show all changes
1250 commits
Select commit Hold shift + click to select a range
3e065cc
Merge pull request #6323 from mozilla/bitecs-object-spawner-permissio…
keianhzo Oct 13, 2023
52de272
Merge pull request #6324 from mozilla/bitecs-object-menu-spawn-check
keianhzo Oct 13, 2023
3e139db
Merge pull request #6327 from mozilla/bitecs-media-link-fix
keianhzo Oct 13, 2023
97b9686
Merge pull request #6320 from mozilla/bitecs-nav-mesh-visibility-fix
keianhzo Oct 13, 2023
3eb8c65
Show avatar menu when inspecting
keianhzo Oct 13, 2023
e7c37fc
Fix avatar hiding
keianhzo Oct 13, 2023
a214c39
Hide inspect prev/next menu for avatars
keianhzo Oct 13, 2023
3b6d99a
Merge pull request #6326 from mozilla/bitecs-nav-mesh-update
keianhzo Oct 19, 2023
ec3fd55
Make nav mesh invisible at load time
keianhzo Oct 19, 2023
6d63790
Better align nav-mesh queries
keianhzo Oct 19, 2023
1a64e83
Merge pull request #6340 from mozilla/bitecs-nav-mesh-fixes
keianhzo Oct 19, 2023
5711df6
Merge pull request #6328 from mozilla/bitecs-avatar-menu-fix
keianhzo Oct 19, 2023
54c5e56
Enforce WebAudio params within limits
keianhzo Oct 19, 2023
ef4fabe
catch resolveUrl exceptions
keianhzo Oct 19, 2023
50736ed
Merge pull request #6341 from mozilla/bitecs-type-checking
keianhzo Oct 23, 2023
70be1cf
Add a raycastable menu background
keianhzo Oct 23, 2023
67f14d4
Add pinning support
keianhzo Sep 13, 2023
979803c
Re-enable conditional signing for pinning
keianhzo Sep 13, 2023
591062d
Add explanation
keianhzo Sep 27, 2023
3c9cbc5
Remove promotional tokes dependency
keianhzo Sep 28, 2023
9def2d5
Fix comment
keianhzo Sep 28, 2023
c2bc0f1
Remove unused imports
keianhzo Sep 28, 2023
47fff87
Revert latest changes
keianhzo Oct 25, 2023
2c75ca2
Add new loader toggle UI in room settings
takahirox Oct 25, 2023
b9f9077
Merge pull request #6354 from mozilla/ToggleNewLoaderUI
takahirox Oct 25, 2023
9c8c2b3
Reload when the new loader is toggled
takahirox Oct 26, 2023
d71e52e
Merge pull request #6355 from mozilla/ReloadIfNewLoaderIsToggled
takahirox Oct 26, 2023
6242146
Rename New Loader
takahirox Oct 26, 2023
ec7e802
Recenter the object menu every frame
keianhzo Oct 27, 2023
b063bf4
Fix menu buttons visibility to account for pinning
keianhzo Oct 27, 2023
e9e6cf1
Fix grabbing to account for pinning perms
keianhzo Oct 27, 2023
8e2e7e0
Remove promotion token
keianhzo Oct 27, 2023
8058e3a
Merge pull request #6356 from mozilla/RenameNewLoader
takahirox Oct 27, 2023
855d396
Fix Browse button layout
takahirox Nov 6, 2023
93d2537
Merge pull request #6361 from mozilla/FixBrowseButton
takahirox Nov 6, 2023
f2f62b9
Fix spawned media menu target resolution
keianhzo Nov 8, 2023
bae070b
Merge pull request #6363 from mozilla/object-menu-link-crash
keianhzo Nov 10, 2023
2ac1b40
Fixes physics and positioning issues with media loader
keianhzo Nov 15, 2023
0c3fd50
First pass additions to media-frames for scale and alignment control
rawnsley Nov 16, 2023
c586250
Merge pull request #6351 from mozilla/bitecs-menu-background
keianhzo Nov 17, 2023
84f9da3
Fix object-menu rendering transparency issues
keianhzo Nov 17, 2023
000ffa1
Merge pull request #6375 from mozilla/bitecs-fix-menu-transparency
keianhzo Nov 17, 2023
bb4651b
Adjustments for special case of video in media frames
rawnsley Nov 17, 2023
e824392
Consider non-unit scaling and media frame bound sizes
rawnsley Nov 17, 2023
03e5a30
Merge branch 'master' into media-frame-alignment
rawnsley Nov 17, 2023
f971cb0
separate animate and physics for reusability
keianhzo Nov 20, 2023
022a200
Spawner fixes
keianhzo Nov 20, 2023
f704ed2
Support for creating a room with parameters using the "new" flag
keianhzo Nov 23, 2023
1c0b4f4
Exclude the "new" flag
keianhzo Nov 23, 2023
b37c6ba
Merge pull request #6383 from mozilla/new-room-params-support
keianhzo Nov 23, 2023
192cae9
Check if nav mesh mesh object exists
keianhzo Nov 23, 2023
982610d
Check if coneOuterGain is defined before clamping its value
keianhzo Nov 23, 2023
56bfe7e
Merge pull request #6384 from mozilla/nav-mesh-exist-check
keianhzo Nov 23, 2023
41cb00a
Merge pull request #6385 from mozilla/check-undefined-coneoutergain
keianhzo Nov 23, 2023
9e214de
Disallow vr_entry_type room limit override
keianhzo Nov 23, 2023
c9d2060
Merge pull request #6386 from mozilla/entry-type-room-limit-override-fix
keianhzo Nov 23, 2023
e61df77
Merge pull request #6371 from mozilla/bitecs-media-loading-updates
keianhzo Nov 27, 2023
d6ccd7e
Fix scalar calculation
keianhzo Nov 27, 2023
d2ea71e
Merge pull request #6387 from mozilla:bitecs-fix-scalar-calc
keianhzo Nov 27, 2023
36a06e5
Check if channel has been created before updating the object menu
keianhzo Nov 27, 2023
6467b94
Merge pull request #6380 from mozilla/bitecs-spawner-transform-animat…
keianhzo Nov 27, 2023
4513538
Fix MediaContent bounds
keianhzo Nov 27, 2023
e6388e3
Merge pull request #6388 from mozilla/bitecs-fix-media-content-bounds
keianhzo Nov 27, 2023
a3b24f6
Fixed lint errors
rawnsley Nov 27, 2023
fbf5d20
Merge pull request #6377 from LearnHub/media-frame-alignment
keianhzo Nov 29, 2023
dfa31bc
Post Media Frame Updates
keianhzo Nov 29, 2023
93116bd
Merge pull request #6389 from mozilla/bitecs-post-media-frame-alignme…
keianhzo Nov 29, 2023
17eac2a
Merge pull request #6287 from mozilla/bitecs-object-list-pinning
keianhzo Nov 29, 2023
daf7ffc
Local media new loader issues fix
keianhzo Nov 29, 2023
e741938
Merge pull request #6390 from mozilla/bitecs-post-merge-fixes
keianhzo Nov 29, 2023
9b72fd9
Media loading scale issue fix
keianhzo Nov 29, 2023
860435e
Merge pull request #6391 from mozilla/bitecs-media-loading-scale-fix
keianhzo Nov 29, 2023
6c07f38
Add object menu link if image controls are enabled
keianhzo Nov 30, 2023
ffe75f9
null check for link source
keianhzo Nov 30, 2023
b746f90
Look for the holdable media root when grabbing an object
keianhzo Nov 30, 2023
230af63
Update video menu layout
keianhzo Nov 30, 2023
8895b7b
Merge pull request #6394 from mozilla/bitecs-video-menu-updates
keianhzo Dec 4, 2023
13d7597
Merge pull request #6393 from mozilla/bitecs-media-link-hold-bug
keianhzo Dec 4, 2023
4ef68d2
Merge pull request #6392 from mozilla/bitecs-image-controls-link-menu
keianhzo Dec 4, 2023
c7bc8af
Use MediaLoader instead of MediaContentBound to find the loader
keianhzo Dec 4, 2023
ad05d74
Fix static media pinnable state
keianhzo Dec 4, 2023
f863046
Fix deletable
keianhzo Dec 4, 2023
009b477
Fix aframe media loading
keianhzo Dec 8, 2023
552ed78
Remove unused import
keianhzo Dec 8, 2023
472c236
Merge pull request #6408 from mozilla/bitecs-static-media-pinnable
keianhzo Dec 11, 2023
31b1f50
Merge pull request #6413 from mozilla/bitecs-aframe-media-fix
keianhzo Dec 11, 2023
08c70ce
Default to empty if scene load fails
keianhzo Dec 12, 2023
d999855
Merge pull request #6415 from mozilla/default-to-empty-if-scene-load-…
keianhzo Dec 13, 2023
0cc0dd8
update lib-hubs to latest commit
kfarr Dec 14, 2023
80c1383
Expose reticulum url
keianhzo Dec 19, 2023
0e5ec47
Merge pull request #6425 from kfarr/cherry-pick-update-lib-hubs
keianhzo Dec 20, 2023
ee6d599
Merge pull request #6257 from paliacci/master
keianhzo Dec 21, 2023
c93db3d
Merge pull request #6238 from LorenzoVonMatterhom/master
keianhzo Dec 21, 2023
9161d6f
Remove comment from it locale
keianhzo Dec 21, 2023
0bc96b6
Update string
keianhzo Dec 21, 2023
9fabfc7
Merge pull request #6427 from mozilla/it-localization-fix
keianhzo Dec 21, 2023
a24ba4f
Add Italian to the available language list
keianhzo Dec 21, 2023
793de26
Merge pull request #6429 from mozilla/add-italian
keianhzo Dec 21, 2023
69ec7be
Compat layer to fully support pen in bitECS
keianhzo Jan 11, 2024
73b6f2c
Merge pull request #6424 from mozilla/expose-ret-url
keianhzo Jan 12, 2024
a303043
BitECS drop button
keianhzo Jan 18, 2024
32cbf34
Prevent camera scaling
keianhzo Jan 19, 2024
4804f77
Merge pull request #6444 from mozilla/prevent-camera-scaling
keianhzo Jan 19, 2024
c16e92f
Merge pull request #6434 from mozilla/pen-bitecs-interactables-compat
keianhzo Jan 22, 2024
8d996ff
Bit media SFX
keianhzo Jan 15, 2024
e9ac511
Bit button SFX
keianhzo Jan 15, 2024
c3ed128
Mic toggle SFX
keianhzo Jan 15, 2024
c003c76
Merge pull request #6436 from mozilla/bit-sfx-update
keianhzo Jan 22, 2024
bf62039
BitECS hover visual effect
keianhzo Jan 15, 2024
d387b18
Merge pull request #6437 from mozilla/bit-hover-effect
keianhzo Jan 22, 2024
f8f4e6f
Limit hover effect to non pinned entities and frozen state
keianhzo Jan 22, 2024
3509ac8
Merge pull request #6446 from mozilla/bitecs-pinned-not-hover-visuals
keianhzo Jan 22, 2024
8ac0b72
Merge pull request #6442 from mozilla/bitecs-drop-button
keianhzo Jan 22, 2024
15ad4de
BitECS Mirror Button
keianhzo Jan 19, 2024
7333f4a
Mute source audio when linking audio media
keianhzo Jan 22, 2024
8545126
Improve menu interaction
keianhzo Jan 22, 2024
14afc90
Merge pull request #6443 from mozilla/bitecs-mirror-button
keianhzo Jan 23, 2024
baa50aa
Improve menu interaction
keianhzo Jan 22, 2024
7299358
BitECS inspect button
keianhzo Jan 19, 2024
8b17df2
Remove unwanted changes
keianhzo Jan 23, 2024
4bfbcbd
Revert to using Deletable in ObjectMenu
keianhzo Jan 23, 2024
3e17530
Fix inspecting focus issues
keianhzo Jan 23, 2024
1f7c920
Merge pull request #6445 from mozilla/bitecs-inspect-button
keianhzo Jan 23, 2024
b0082b9
Disable the hover effect while in inspect mode
keianhzo Jan 23, 2024
494b3bb
Merge pull request #6447 from mozilla/bitecs-improve-menu-interaction
keianhzo Jan 23, 2024
fead7c9
Merge pull request #6448 from mozilla/no-hover-effect-inspect
keianhzo Jan 23, 2024
aedfafa
Deselect objects when the object sidebar is closed
keianhzo Jan 23, 2024
bf4927c
Merge pull request #6449 from mozilla/inspect-fix-object-list-closed
keianhzo Jan 23, 2024
bb60afa
Handle inspected entity removal cases gracefully
keianhzo Jan 24, 2024
add9afa
Merge pull request #6450 from mozilla/bitecs-inspect-bug-fix
keianhzo Jan 24, 2024
3cbd8f5
BitECS snap object menu support
keianhzo Jan 24, 2024
862c74a
Do not show snap button for audio media
keianhzo Jan 24, 2024
75efc61
Place snapped object around original
keianhzo Jan 24, 2024
ced6609
Merge pull request #6451 from mozilla/bitecs-snap-object-menu
keianhzo Jan 24, 2024
2a38a13
Volume controls in the video menu
keianhzo Jan 24, 2024
889701f
Check if current gain is undefined
keianhzo Jan 24, 2024
8411cd7
Merge pull request #6452 from mozilla/bitecs-video-menu-volume
keianhzo Jan 25, 2024
c23df7c
BitECS object menu refresh button
keianhzo Jan 25, 2024
35eb38e
Merge pull request #6453 from mozilla/bitecs-object-menu-refresh
keianhzo Jan 25, 2024
cba5e2b
Fix menus scale
keianhzo Jan 25, 2024
22dd263
Merge pull request #6454 from mozilla/bitecs-menu-size-fix
keianhzo Jan 25, 2024
a53a4e4
Fix video controls visibility
keianhzo Jan 25, 2024
83ac743
Scale only pdf and video menus
keianhzo Jan 25, 2024
9315087
Merge pull request #6456 from mozilla/bitecs-scale-menu-only-pdf-video
keianhzo Jan 25, 2024
14c3e35
Merge pull request #6455 from mozilla/bitecs-hide-audio-if-no-controls
keianhzo Jan 25, 2024
6b94772
Fix spawned media sliding
keianhzo Jan 25, 2024
852d3cb
Merge pull request #6457 from mozilla/bitecs-fix-loading-transition
keianhzo Jan 25, 2024
4eca39b
Add unprivileged object menu and layout update
keianhzo Jan 25, 2024
fba1b4c
Merge pull request #6458 from mozilla/bitcs-unpriv-object-menu
keianhzo Jan 25, 2024
9a68731
BitECS focus/track object menu support
keianhzo Jan 25, 2024
a088649
Merge pull request #6459 from mozilla/bitecs-object-menu-focus
keianhzo Jan 25, 2024
928d14a
Fix position of inspect buttons when the object is droppable
keianhzo Jan 25, 2024
4586072
Merge pull request #6460 from mozilla/bitecs-fix-object-menu-buttons-…
keianhzo Jan 25, 2024
f779a8e
Avoid crash when cloning Troika text
keianhzo Jan 26, 2024
9ed5183
Merge pull request #6461 from mozilla/frame-preview-fixes
keianhzo Jan 26, 2024
66896f6
Handle grab scaled object
keianhzo Jan 26, 2024
0ee6757
Merge pull request #6462 from mozilla/bitecs-scale-grabbed
keianhzo Jan 26, 2024
af9c696
Force a matrix world update when audio is created
keianhzo Jan 26, 2024
a8208fc
Merge pull request #6463 from mozilla/invisible-audio-fix
keianhzo Jan 26, 2024
0795abd
Fix avatar self inspection
keianhzo Feb 13, 2024
bf6ed63
Merge pull request #6469 from mozilla/bitecs-fix-inspect
keianhzo Feb 13, 2024
3e56b44
Update SECURITY.md
keianhzo Mar 18, 2024
190aca0
Merge pull request #6477 from mozilla/keianhzo-patch-1
keianhzo Mar 18, 2024
12393a9
Fix pen VR
keianhzo Mar 18, 2024
cc3c62d
Remove unused imports
keianhzo Mar 20, 2024
746413d
Merge pull request #6478 from mozilla/bitecs-fix-pen
keianhzo Mar 26, 2024
ec12e4c
Scene grabbables support
keianhzo May 2, 2024
ae050ee
Revert media collision mask
keianhzo May 8, 2024
c23b7d4
Add warning for negative scale when creating interactables bounds
keianhzo May 8, 2024
4324d10
Merge pull request #6487 from mozilla/scene-grabbables
keianhzo May 8, 2024
eccb840
Initial add-ons API commit
keianhzo Jan 29, 2024
4e69cb6
Try to get some more info about the build error
keianhzo Feb 15, 2024
1b48d6e
Do not install dev dependencies in production
keianhzo Feb 15, 2024
3cc6d09
Revert tests
keianhzo Feb 15, 2024
f3d84cc
organize types
keianhzo Feb 15, 2024
4ff2d0e
Test
keianhzo Feb 22, 2024
460930f
Omit dev packages when installing deps in production
keianhzo Apr 10, 2024
3726836
Package lock update
keianhzo Apr 10, 2024
2781f1f
Increase log level
keianhzo Apr 10, 2024
ca5a91e
Try --legacy-peer-deps
keianhzo Apr 10, 2024
4a432f9
Use webpack in addons instead of tsup
keianhzo Apr 17, 2024
f0da86a
Revert docker image changes
keianhzo Apr 17, 2024
174c6fa
Remove portals addon
keianhzo Apr 17, 2024
56f6567
Update addon version
keianhzo Apr 18, 2024
f3d12c4
Update addons
keianhzo Apr 24, 2024
2240897
BGs initial support
keianhzo May 8, 2024
0956082
Packages updates
keianhzo May 8, 2024
5920ae4
Better handle of bitECS/addons state
keianhzo May 9, 2024
fe03f9c
Add lost trigger collision group
keianhzo May 10, 2024
4f4f186
Skip homepage when creating a new room
keianhzo May 10, 2024
5beeac1
Update BGs add-on
keianhzo May 10, 2024
b16f757
Add-ons docs
keianhzo May 13, 2024
e03ce8b
Fix format
keianhzo May 13, 2024
672c680
Fix image size
keianhzo May 13, 2024
644d101
Restore dockerfile
keianhzo May 13, 2024
d616838
Add add-on preferences update support
keianhzo May 21, 2024
129b460
Add post-processing addon
keianhzo May 23, 2024
7c20ad5
Use legacy peers for storybook
keianhzo May 23, 2024
905abd9
Pin addons versions
keianhzo May 24, 2024
02255be
Update README.md
Jacob-Ervin May 24, 2024
c3f8f7a
Merge pull request #6491 from mozilla/Jacob-Ervin-patch-1
Jacob-Ervin May 24, 2024
c02bb8d
remove unnecessary legacy-peer-deps
keianhzo Jun 3, 2024
5b9ce83
Fix admin store access
keianhzo Jun 3, 2024
bccf94d
Update admin store ref
keianhzo Jun 3, 2024
064441a
Fix addon configuration
keianhzo Jun 13, 2024
a753cc1
Remove Mozilla references and links.
Exairnous Aug 4, 2024
3414011
Remove Mozilla references from PROMOTION.md
Exairnous Aug 6, 2024
5e74413
Remove or replace Mozilla branding images and videos.
Exairnous Aug 6, 2024
a86b8ec
Update the Invite Bot to Server link/button on the Discord page.
Exairnous Aug 6, 2024
a300df7
Fix formatting.
Exairnous Aug 6, 2024
ae02b3b
update locale and copy regarding Powered by "Mozilla Hub"
tksham Aug 10, 2024
6b4a42e
update remaining local and link of hubsfoundation.org
tksham Aug 11, 2024
5ee2350
Merge pull request #6494 from tksham/mozilla-branding-removal-1
Exairnous Aug 15, 2024
699187a
Initialize transform matrix to avoid undefined index references
rawnsley Aug 19, 2024
49fe109
Merge pull request #6495 from rawnsley/matrix-init-for-browser-freeze
Exairnous Aug 28, 2024
f3c685e
Merge pull request #6493 from Hubs-Foundation/mozilla-branding-removal-1
Exairnous Aug 30, 2024
daaae65
Use the Hubs Foundation's docker hub repository for building and push…
Exairnous Sep 8, 2024
9357a37
Comment out the Smoke test section as the Hubs Foundation doesn't hav…
Exairnous Sep 8, 2024
86378ea
Merge pull request #6498 from Hubs-Foundation/hubsfoundation-docker-r…
Exairnous Sep 8, 2024
1567f22
Eliminates warnings by prettier and caniuse-lite
DougReeder Sep 12, 2024
33ed11f
Merge pull request #6499 from DougReeder/eliminate-warnings
Exairnous Sep 24, 2024
313e559
Invites & sharing Room URL use Web Share API if available
DougReeder Sep 30, 2024
017a30a
Sharing invite: hostname is now always correct & l10n strings corrected
DougReeder Oct 3, 2024
306ff67
Share Invitation incorporates text from configuration & option to sha…
DougReeder Oct 5, 2024
98e85c4
Invite using Web Share API: hides "Share in English" when locale is E…
DougReeder Oct 8, 2024
5098d29
Invite using Web Share API: improves German translation
DougReeder Oct 8, 2024
730a9d2
Fixes lint complaints
DougReeder Oct 28, 2024
95a08fc
Merge pull request #6508 from DougReeder/web-share-api
Exairnous Oct 29, 2024
fdd587c
Adds Share button to picture and video items in Chat
DougReeder Oct 15, 2024
90f2b0e
Scene page: replaces 'Share on Twitter' w/ 'Share' (using Web Share API)
DougReeder Oct 16, 2024
c0adadd
Merge pull request #6511 from DougReeder/chat-share
Exairnous Oct 31, 2024
e5eb1a2
Merge pull request #6512 from DougReeder/scene-share
Exairnous Oct 31, 2024
036565e
HUD Invite button: fixes by calling System Share API directly
DougReeder Oct 7, 2024
babb4a2
Merge pull request #6510 from DougReeder/vr-invite
Exairnous Nov 1, 2024
0dabc28
Revert Scene grabbables support PR and fix the bugs caused by it
Exairnous Nov 7, 2024
7615e93
Fixes layout bug in chat sidebar introduced by PR #6511
DougReeder Nov 8, 2024
0bd77cb
Merge pull request #6516 from DougReeder/chat-bubble-fix
Exairnous Nov 15, 2024
392782e
Merge branch 'master' into addons
Exairnous Nov 15, 2024
ec5835b
[Mozilla Branding Removal] Update dependency links
Exairnous Nov 15, 2024
b0c1a7a
Unpin addons versions
Exairnous Nov 15, 2024
7a99b6f
Make dependency URL capitalization consistent
Exairnous Nov 15, 2024
be1d82d
Merge pull request #6515 from Hubs-Foundation/revert-scene-grabbables…
Exairnous Nov 17, 2024
e449f66
Merge branch 'master' into addons (likely breaks the branch)
Exairnous Nov 17, 2024
348c602
Revert "Merge branch 'master' into addons (likely breaks the branch)"
Exairnous Nov 17, 2024
9ffe97b
Partially fix rotating and scaling via the spacebar menu buttons
Exairnous Nov 1, 2024
8d28f61
Resolved merge conflict in package-lock.json
HussainAther Feb 11, 2025
6ab775d
Resolved merge conflicts in package-lock.json
HussainAther Feb 12, 2025
50d13ce
safeguard incldued
HussainAther Mar 7, 2025
4f60634
Improved link validation and debugging in gltf-model-plus.js
HussainAther Mar 7, 2025
1bde44b
indentation fix
HussainAther Mar 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/components/gltf-model-plus.js
Original file line number Diff line number Diff line change
Expand Up @@ -595,15 +595,17 @@ class GLTFHubsComponentsExtension {
// Note: For some reason this was not supported for PDFs. Not sure if it's random or if there is a reason.
if (shouldUseNewLoader()) {
if (Object.prototype.hasOwnProperty.call(ext, "link")) {
if (["image", "video", "model"].includes(componentName)) {
if (["image", "video", "model"].includes(componentName)) {
if (!ext.link || !ext.link.href) {
console.warn("Warning: Attempted to load a link but the href is missing!", ext);
} else {
ext["media-link"] = {
src: ext.link.href
};
delete ext.link;
}
}
}

src: ext.link.href
};
delete ext.link;
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please fix the indentation.

Copy link
Author

@HussainAther HussainAther Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, how exact should I fix it?

EDIT: Ok, I see it now. Thanks. It should be just be two spaces.

const value = props[propName];
const type = value?.__mhc_link_type;
if (type && value.index !== undefined) {
Expand Down