fix: BROS-708: Zoom shape corruption #9159
Open
+0
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #9159 +/- ##
===========================================
- Coverage 66.12% 57.97% -8.15%
===========================================
Files 828 557 -271
Lines 64797 40371 -24426
Branches 10939 10927 -12
===========================================
- Hits 42846 23407 -19439
+ Misses 21947 16960 -4987
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yyassi-heartex
approved these changes
Jan 12, 2026
Contributor
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
was this not used else where? cleanup is great i just want to make sure we're not removing things un-expectedly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue when dragging shape points in zoomed-in view would cause abrupt zoom reset and shape corruption.
The root cause was in the legacy transformation logic (pre-group-transform) that was running after every transform of a shape. This logic was unnecessary in the current setup and group transformations (multi-shape) are handled elsewhere.
Removing the logic fixes the bug, zoom reset doesn't happen anymore, shape stays stable after all transformations.